Closed Bug 2060986 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 61759 - Don't reuse base style with 'display: none' when animating display

Categories

(Core :: CSS Transitions and Animations, task, P4)

task

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61759
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Don't reuse base style with 'display: none' when animating display

Companion to the condition in StyleResolverState::LoadPendingResources.
If the base style is created before the element is transition/animated
we may have created a ComputedStyle with a StylePendingImage.

Extend the test from issue 496524440, because the minimized testcase
from this bug matches it exactly.

Fixed: 525810815
Change-Id: Iaadc3819b860c51098c6d679b0cdd60ed3a2c35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8130898
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Auto-Submit: Fredrik Söderquist \<fs@opera.com>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1674165}

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 139 tests

Status Summary

Firefox

OK : 110[Gecko-android-em-14-x86_64-debug-geckoview] 111[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 13[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1355[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1356[Gecko-android-em-14-x86_64-debug-geckoview] 1361[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 18

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a11391b7ce5b https://hg.mozilla.org/integration/autoland/rev/daa15ece77e5 [wpt PR 61759] - Don't reuse base style with 'display: none' when animating display, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.