[wpt-sync] Sync PR 61759 - Don't reuse base style with 'display: none' when animating display
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61759 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61759
Details from upstream follow.
Fredrik Söderquist <fs@opera.com> wrote:
Don't reuse base style with 'display: none' when animating display
Companion to the condition in StyleResolverState::LoadPendingResources.
If the base style is created before the element is transition/animated
we may have created a ComputedStyle with a StylePendingImage.Extend the test from issue 496524440, because the minimized testcase
from this bug matches it exactly.Fixed: 525810815
Change-Id: Iaadc3819b860c51098c6d679b0cdd60ed3a2c35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8130898
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Auto-Submit: Fredrik Söderquist \<fs@opera.com>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1674165}
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c849bd27b1b5f44c5170bcf636b3e0e7b232788
| Assignee | ||
Comment 2•3 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 139 tests
Status Summary
Firefox
OK : 110[Gecko-android-em-14-x86_64-debug-geckoview] 111[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 13[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1355[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1356[Gecko-android-em-14-x86_64-debug-geckoview] 1361[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 18
Chrome
PASS: 1
Safari
PASS: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-transitions/before-load-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-002.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-003.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-implicit-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-002.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-003.html [wpt.fyi]:
SKIP - /css/css-transitions/pseudo-elements-001.html [wpt.fyi]:
SKIP - /css/css-transitions/CSSTransition-not-canceling.tentative.html [wpt.fyi]
- Setting "display: none" with "display" set to transition using "display 100s allow-discrete" does not cancel running transitions:
FAIL - Setting "display: none" with "display" set to transition using "display 100s, all allow-discrete 100s" does not cancel running transitions:
FAIL
- Setting "display: none" with "display" set to transition using "display 100s allow-discrete" does not cancel running transitions:
- /css/css-transitions/CSSTransition-startTime.tentative.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /css/css-transitions/after-change-style-inherited-try-fallback.html [wpt.fyi]
- Position fallback correctly applied to after-change style:
FAIL
- Position fallback correctly applied to after-change style:
- /css/css-transitions/idlharness-2.html [wpt.fyi]
- Partial interface TransitionEvent: original interface defined:
FAIL - Partial dictionary TransitionEventInit: original dictionary defined:
FAIL
- Partial interface TransitionEvent: original interface defined:
- /css/css-transitions/starting-style-size-container.html [wpt.fyi]
- Triggered transition from first style update based on up-to-date container query:
FAIL
- Triggered transition from first style update based on up-to-date container query:
- /css/css-transitions/unregistered-custom-property-transition.html [wpt.fyi]
- first value -> unset transition with allow-discrete:
FAIL
- first value -> unset transition with allow-discrete:
- /css/css-transitions/animations/animate-with-color-mix.html [wpt.fyi]
- Transition from color-mix to legacy rgb:
FAIL - Transition from legacy rgb to color-mix:
FAIL - Transition from color-mix to srgb:
FAIL - Transition from srgb to color-mix:
FAIL - Transition from color-mix with transparency to legacy rgba:
FAIL - Transition from legacy rgba to color-mix with transparency:
FAIL
- Transition from color-mix to legacy rgb:
- /css/css-transitions/parsing/transition-timing-function-computed.html [wpt.fyi]
- Property transition-timing-function value 'steps(calc(2 * sibling-index()), jump-none)':
FAIL - Property transition-timing-function value 'steps(sibling-index(), jump-none)':
FAIL - Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), jump-none)':
FAIL - Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), start)':
FAIL
- Property transition-timing-function value 'steps(calc(2 * sibling-index()), jump-none)':
- /css/css-transitions/parsing/transition-timing-function-valid.html [wpt.fyi]
- e.style['transition-timing-function'] = "steps(sibling-index(), jump-none)" should set the property value:
FAIL
- e.style['transition-timing-function'] = "steps(sibling-index(), jump-none)" should set the property value:
Tests Disabled in Gecko Infrastructure
- /css/css-transitions/before-load-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-002.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-003.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-implicit-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-001.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-002.html [wpt.fyi]:
SKIP - /css/css-transitions/properties-value-inherit-003.html [wpt.fyi]:
SKIP - /css/css-transitions/pseudo-elements-001.html [wpt.fyi]:
SKIP - /css/css-transitions/CSSTransition-startTime.tentative.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview]
Comment 4•3 months ago
|
||
| bugherder | ||
Description
•