Closed Bug 2060996 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 61765 - Fix button markup in focus-visible WPTs

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61765 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61765
Details from upstream follow.

Fernando Fiori <ffiori@microsoft.com> wrote:

Fix button markup in focus-visible WPTs

Close the test buttons with matching tags so later focus targets remain
sibling elements instead of button descendants.

Bug: 542686202
Change-Id: I051cdb3f46225cf8456e7ae8ac0c9366df19deca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8194513
Reviewed-by: Fernando Fiori \<ffiori@microsoft.com>
Reviewed-by: Ana Sollano Kim \<ansollan@microsoft.com>
Auto-Submit: Fernando Fiori \<ffiori@microsoft.com>
Commit-Queue: Fernando Fiori \<ffiori@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1674268}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 811 tests and 10 subtests

Status Summary

Firefox

OK : 2[GitHub] 451[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 19[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 22[GitHub] 5909[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 6243[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 6244[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 6245[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 143[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 148[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 149[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PRECONDITION_FAILED: 1

Chrome

OK : 2
PASS : 22

Safari

PASS : 6
TIMEOUT : 4
NOTRUN : 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/selectors/featureless-005.html [wpt.fyi]: FAIL
  • /css/selectors/is-default-ns-003.html [wpt.fyi]: FAIL
  • /css/selectors/is-where-visited.html [wpt.fyi]: FAIL
  • /css/selectors/not-default-ns-003.html [wpt.fyi]: FAIL
  • /css/selectors/remove-hovered-element.html [wpt.fyi]: PASS [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
  • /css/selectors/i18n/lang-pseudo-class-across-shadow-boundaries.html [wpt.fyi]: FAIL
  • /css/selectors/invalidation/lang-pseudo-class-in-has-multiple-document-elements.html [wpt.fyi]: FAIL [Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
  • /css/selectors/active-toplayer-001.html [wpt.fyi]
    • Clicking inside a modal dialog should not propagate :active beyond the dialog.: FAIL
    • Clicking inside a popover should not propagate :active beyond the popover.: FAIL
    • With nested top layer elements, :active should stop at the innermost top layer boundary.: FAIL
  • /css/selectors/focus-visible-007.html [wpt.fyi]
    • Using keyboard while element is focused should trigger :focus-visible; using mouse without moving focus should not cancel it; moving focus using mouse should cancel it.: FAIL
  • /css/selectors/focus-visible-011.html [wpt.fyi]
    • :focus-visible matches even if preventDefault() is called: FAIL
  • /css/selectors/focus-within-toplayer-001.html [wpt.fyi]
    • Focusing inside a modal dialog should not propagate :focus-within beyond the dialog.: FAIL
    • Focusing inside a popover should not propagate :focus-within beyond the popover.: FAIL
    • With nested top layer elements, :focus-within should stop at the innermost top layer boundary.: FAIL
  • /css/selectors/heading-prefixed.html [wpt.fyi]
    • :heading(1) matches <h:h1> in the HTML namespace: FAIL
    • :heading(2) matches <h:h2> in the HTML namespace: FAIL
    • :heading(3) matches <h:h3> in the HTML namespace: FAIL
    • :heading(4) matches <h:h4> in the HTML namespace: FAIL
    • :heading(5) matches <h:h5> in the HTML namespace: FAIL
    • :heading(6) matches <h:h6> in the HTML namespace: FAIL
  • /css/selectors/hover-toplayer-001.html [wpt.fyi]
    • Hovering inside a modal dialog should not propagate :hover beyond the dialog.: FAIL
    • Hovering inside a popover should not propagate :hover beyond the popover.: FAIL
    • With nested top layer elements, :hover should stop at the innermost top layer boundary.: FAIL
  • /css/selectors/is-where-shadow.html [wpt.fyi]
    • :is() inside :host-context(): FAIL
  • /css/selectors/open-pseudo.html [wpt.fyi]
    • The select element should support :open.: FAIL [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview], PASS [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
  • /css/selectors/toplayer-transition-001.html [wpt.fyi]
    • :focus-within should be adjusted on ancestors when popover enters/exits top layer.: FAIL
    • :hover should be adjusted on ancestors when popover enters/exits top layer.: FAIL
  • /css/selectors/user-action-pseudo-top-layer.html [wpt.fyi]
    • User action pseudo-classes on dialog (modal): FAIL
    • User action pseudo-classes on popover (popover): FAIL
    • User action pseudo-classes on customizable-select (open): PRECONDITION_FAILED
  • /css/selectors/user-invalid.html [wpt.fyi]
    • A required date should match :user-invalid if the user unchecks it and blurs.: FAIL
  • /css/selectors/user-valid-user-invalid-multifield-inputs.tentative.html [wpt.fyi]
    • <input type=date> keyboard behavior for :user-valid/:user-invalid.: FAIL
    • <input type=time> keyboard behavior for :user-valid/:user-invalid.: FAIL
    • <input type=datetime-local> keyboard behavior for :user-valid/:user-invalid.: FAIL
  • /css/selectors/user-valid.html [wpt.fyi]
    • Date inputs should match :user-valid after the user types a value into it.: FAIL
  • /css/selectors/invalidation/heading-pseudo-class-in-has-with-headingoffset.html [wpt.fyi]
    • Initial colors: #has_heading_1: FAIL
    • Initial colors: #has_heading_1_2: FAIL
    • h1[headingoffset=1]: #has_heading_2: FAIL
    • h1[headingoffset=1]: #has_heading_1_2: FAIL
    • h1[headingoffset=2]: #has_heading_3: FAIL
    • h1 with headingoffset removed: #has_heading_1: FAIL
    • h1 with headingoffset removed: #has_heading_1_2: FAIL
    • ancestor[headingoffset=1]: #has_heading_2: FAIL
    • ancestor[headingoffset=1]: #has_heading_1_2: FAIL
    • ancestor[headingoffset=2]: #has_heading_3: FAIL
    • h1[headingreset] (cuts ancestor offset): #has_heading_1: FAIL
    • h1[headingreset] (cuts ancestor offset): #has_heading_1_2: FAIL
    • h1 with headingreset removed: #has_heading_3: FAIL
    • ancestor with headingoffset removed: #has_heading_1: FAIL
    • ancestor with headingoffset removed: #has_heading_1_2: FAIL
    • h1.headingOffset = 1: #has_heading_2: FAIL
    • h1.headingOffset = 1: #has_heading_1_2: FAIL
    • h1.headingOffset = 0: #has_heading_1: FAIL
    • h1.headingOffset = 0: #has_heading_1_2: FAIL
    • ancestor[headingoffset=2] again: #has_heading_3: FAIL
    • h1.headingReset = true: #has_heading_1: FAIL
    • h1.headingReset = true: #has_heading_1_2: FAIL
    • h1.headingReset = false: #has_heading_3: FAIL
  • /css/selectors/invalidation/heading-pseudo-class-in-has-with-slot-reassignment.html [wpt.fyi]
    • Initial (h1 slotted into slot_a): #has_heading_1: FAIL
    • h1.slot = 'b': #has_heading_1: FAIL
    • h1.slot = 'nonexistent': #has_heading_1: FAIL
    • h1.slot = 'a': #has_heading_1: FAIL
    • slotA.name = 'c': #has_heading_1: FAIL
    • slotB.name = 'a': #has_heading_1: FAIL
    • Reset slot names: #has_heading_1: FAIL
    • slotA.remove(): #has_heading_1: FAIL
    • Re-insert slot_a: #has_heading_1: FAIL
    • ancestor[headingoffset=2]: #has_heading_3: FAIL
    • h1.slot = 'b' with ancestor[headingoffset=2]: #has_heading_3: FAIL
    • ancestor[headingoffset=4]: #has_heading_5: FAIL
    • ancestor with headingoffset removed: #has_heading_1: FAIL
  • /css/selectors/invalidation/heading-pseudo-class-in-has.html [wpt.fyi]
    • Append h1 to #ancestor: #has_heading_1: FAIL
    • Append h1 to #ancestor: #has_heading_1_2: FAIL
    • Append h2 to #ancestor: #has_heading_1: FAIL
    • Append h2 to #ancestor: #has_heading_2: FAIL
    • Append h2 to #ancestor: #has_heading_1_2: FAIL
    • Append h3 to #ancestor: #has_heading_1: FAIL
    • Append h3 to #ancestor: #has_heading_2: FAIL
    • Append h3 to #ancestor: #has_heading_3: FAIL
    • Append h3 to #ancestor: #has_heading_1_2: FAIL
    • Remove h1 from #ancestor: #has_heading_2: FAIL
    • Remove h1 from #ancestor: #has_heading_3: FAIL
    • Remove h1 from #ancestor: #has_heading_1_2: FAIL
    • Remove h2 from #ancestor: #has_heading_3: FAIL
    • Insert h1 adjacent to #sibling: #has_adjacent_heading_1: FAIL
    • Insert h1 adjacent to #sibling: #adjacent_heading_1: FAIL
    • Replace div with h1 in #ancestor: #has_heading_1: FAIL
    • Replace div with h1 in #ancestor: #has_heading_1_2: FAIL
  • /css/selectors/invalidation/host-context-pseudo-class-in-has.html [wpt.fyi]
    • After adding 'a' to #host_parent: Check #subject1 color: FAIL
    • After adding 'a' to #host_parent: Check #subject2 color: FAIL
  • /css/selectors/invalidation/host-has-shadow-tree-element-at-nonsubject-position.html [wpt.fyi]
    • Add .descendant to #shadow_child: FAIL
    • Add .descendant to #shadow_descendant: FAIL
    • Add .ancestor to #shadow_child:has(.descendant): FAIL
    • Remove .ancestor from #shadow_child:has(.descendant): FAIL
    • Add .child to #shadow_child:has(.descendant): FAIL
    • Remove .child from #shadow_child:has(.descendant): FAIL
    • Add .child to #shadow_child: FAIL
    • Add .grand_child to #shadow_descendant: FAIL
    • Add .host_context to #host: FAIL
    • Add .descendant to #shadow_descendant.grand_child: FAIL
    • Remove .descendant from #shadow_descendant.grand_child: FAIL
    • Remove .grand_child from #shadow_descendant: FAIL
    • Insert #first_child.descendant to shadow root: FAIL
    • Insert #last_child.descendant to shadow root: FAIL
    • Insert #child_in_middle.descendant before #shadow_child: FAIL
    • Insert #grand_child.descendant before #shadow_descendant: FAIL
  • /css/selectors/invalidation/host-has-shadow-tree-element-at-subject-position.html [wpt.fyi]
    • Add .descendant to #shadow_child: FAIL
    • Add .descendant to #shadow_descendant: FAIL
    • Add .ancestor to #shadow_child:has(.descendant): FAIL
    • Remove .ancestor from #shadow_child:has(.descendant): FAIL
    • Add .child to #shadow_child:has(.descendant): FAIL
    • Remove .child from #shadow_child:has(.descendant): FAIL
    • Add .child to #shadow_child: FAIL
    • Add .grand_child to #shadow_descendant: FAIL
    • Add .host_context to #host: FAIL
    • Add .descendant to #shadow_descendant.grand_child: FAIL
    • Remove .descendant from #shadow_descendant.grand_child: FAIL
    • Remove .grand_child from #shadow_descendant: FAIL
    • Insert #first_child.descendant to shadow root: FAIL
    • Insert #last_child.descendant to shadow root: FAIL
    • Insert #child_in_middle.descendant before #shadow_child: FAIL
    • Insert #grand_child.descendant before #shadow_descendant: FAIL
  • /css/selectors/invalidation/option-disabled-when-ancestor-changes.html [wpt.fyi]
    • option :disabled and :has(option:disabled) invalidate when ancestor select disabled toggles: FAIL
    • optgroup :disabled and :has(optgroup:disabled) invalidate when ancestor select disabled toggles: FAIL
    • option :disabled and :has(option:disabled) invalidate when ancestor fieldset disabled toggles: FAIL
    • optgroup :disabled and :has(optgroup:disabled) invalidate when ancestor fieldset disabled toggles: FAIL
  • /css/selectors/invalidation/part-lang.html [wpt.fyi]
    • ::part():lang() invalidation: FAIL
    • ::part():lang() invalidation from setAttribute: FAIL
  • /css/selectors/old-tests/css3-modsel-22.xml [wpt.fyi]
    • li:lang(en-GB) matches: FAIL
  • /css/selectors/parsing/parse-has-slotted.tentative.html [wpt.fyi]
    • ":has-slotted(bar)" should be a valid selector: FAIL
    • ":has-slotted([attr="foo"])" should be a valid selector: FAIL
    • ":has-slotted(*)" should be a valid selector: FAIL
    • ":has-slotted(.class)" should be a valid selector: FAIL
    • ":has-slotted(#id)" should be a valid selector: FAIL
    • ":has-slotted(:not(foo))" should be a valid selector: FAIL
    • ":has-slotted(:not(:nth-last-of-type(2)):not([slot="foo"]))" should be a valid selector: FAIL
    • ":has-slotted(:first-child)" should be a valid selector: FAIL
    • ":has-slotted(:hover)" should be a valid selector: FAIL
    • ":has-slotted(foo):first-child" should be a valid selector: FAIL
    • ":has-slotted(foo):hover" should be a valid selector: FAIL
    • ":has-slotted(foo):focus" should be a valid selector: FAIL
    • ":has-slotted(foo):lang(en)" should be a valid selector: FAIL
    • ":has-slotted(foo):dir(ltr)" should be a valid selector: FAIL
    • ":has-slotted(foo) + :has-slotted(bar)" should be a valid selector: FAIL
    • ":not(:has-slotted(foo))" should be a valid selector: FAIL
    • ":has-slotted(div + div)" should be a valid selector: FAIL
    • ":has-slotted(div:has(> span))" should be a valid selector: FAIL
  • /css/selectors/selectors-4/lang-singleton-subtag-matching.html [wpt.fyi]
    • :lang(fr-x) matches lang="fr-x" and lang="fr-x-standard" (singleton "x" matches): FAIL
    • :lang(fr-x) matches the correct elements: FAIL
    • :lang(fr) does not match lang="fr-ninechars" (subtag exceeds 8-char limit): FAIL
    • :lang(zh-x) matches both lang="zh-x" and lang="zh-x-foobar": FAIL

Tests Disabled in Gecko Infrastructure

  • /css/selectors/remove-hovered-element.html [wpt.fyi]: PASS [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.