2061031 - Add plumbing for vpn.error_encountered probes to send the error_code onward

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task)

Description

[Jonathan Almeida [:jonalmeida]]

We have the probe from bug 2031198, but we never added the plumbing to send it through when an error occurs. This makes it harder for us to know what error occurred when we activate/deactivate.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2061031 - Add the error from IPProtectionController to vpn.error_encountered r?sstreich,mavduevskiy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4ec7d2356a6
https://hg.mozilla.org/integration/autoland/rev/725147790f19
Add the error from IPProtectionController to vpn.error_encountered r=geckoview-reviewers,android-reviewers,kaya

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a8d6dd42ad6a
https://hg.mozilla.org/integration/autoland/rev/e887d13b2393
Revert "Bug 2061031 - Add the error from IPProtectionController to vpn.error_encountered r=geckoview-reviewers,android-reviewers,kaya" for causing gv-junit failures on ipProxyExceptionUnknownErrorStringsMapsToErrorUnknown.

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing gv-junit failures on ipProxyExceptionUnknownErrorStringsMapsToErrorUnknown.

Push with failures

Failure log

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d92cc9c302c9
https://hg.mozilla.org/integration/autoland/rev/3fc6ebbc3f9a
Add the error from IPProtectionController to vpn.error_encountered r=geckoview-reviewers,android-reviewers,kaya

Comment 6

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/3fc6ebbc3f9a

Comment 7

[Jonathan Almeida [:jonalmeida]]

Clearing NI; this was landed with the gv hash version fixed.

Comment 8

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2061031 - Add the error from IPProtectionController to vpn.error_encountered

Original Revision: https://phabricator.services.mozilla.com/D316675

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The IPProtection feature on Android that started rolling out identified that a large portion of the users that interacted with the feature faced at least one error.

These patches fix the errors that users were seeing and also increased the telemetry needed to identify the types of errors that a user would have encountered if they happen again. With them, the feature roll-out is possible to continue.

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: STR can be found in bug 2061841 and bug 2061846.
• Risk associated with taking this patch: medium
• Explanation of risk level: The first three patches in nightly can be considered "low" because they have been tested and verified amongst multiple people for feature stability. D317232 has only recently landed and we haven't yet seen data come in from Nightly for full verification - as such, I've marked the combined stack as 'medium'.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The IPProtection feature on Android that started rolling out identified that a large portion of the users that interacted with the feature faced at least one error.

These patches fix the errors that users were seeing and also increased the telemetry needed to identify the types of errors that a user would have encountered if they happen again. With them, the feature roll-out is possible to continue.

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: STR can be found in bug 2061841 and bug 2061846.
• Risk associated with taking this patch: medium
• Explanation of risk level: The first three patches in nightly can be considered "low" because they have been tested and verified amongst multiple people for feature stability. D317232 has only recently landed and we haven't yet seen data come in from Nightly for full verification - as such, I've marked the combined stack as 'medium'.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2558e96802cc
https://hg.mozilla.org/releases/mozilla-beta/rev/80733a763366

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7eaa1417e0e7
https://hg.mozilla.org/releases/mozilla-beta/rev/c8e745703b9b

Comment 13

[Dianna Smith [:diannaS]]

Backed out for android failures

https://treeherder.mozilla.org/jobs?repo=mozilla-beta&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2Ccomponents%2Copt%2Cfeature-ipprotection%2Cbuild-components-feature-ipprotection%2Cb&fromchange=d2cfd77d700eeef54544d3fbfe3fdaffbcf7e9da

Comment 14

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2061031 - Add the error from IPProtectionController to vpn.error_encountered

Original Revision: https://phabricator.services.mozilla.com/D316675

Comment 15

[Jonathan Almeida [:jonalmeida]]

I've re-pushed again with the test failures fixed and a new try build to verify that: https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=76978

I'll wait for the build to pass before I removed the need-info.

Sorry about the trouble and wasting your time, I skipped a step before submitting that I should have caught.

Comment 16

[Jonathan Almeida [:jonalmeida]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #15)

I'll wait for the build to pass before I removed the need-info.

Try build is all green.

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/21b0d9b1fafb
https://hg.mozilla.org/releases/mozilla-beta/rev/b438f1bca9bf

Comment 18

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Attachment: video_new53.mp4

Hi Jonathan,

I haven't been able to reproduce the "Couldn't connect to VPN" and "Continue without VPN?" errors right after sign-in. Should I trigger these errors manually to check the telemetry? Also, could you let me know what specific changes were made to the telemetry so I know what to check for?

The builds listed below were verified using a Google Pixel 7a running Android 16:

• Fx 154.0b9 (Build #2016177354) – build containing fixes for the snapshot of errors
• Fx Nightly 155.0a1 (Build #2016177823)

Please let me know if any additional builds are needed for verification.

Thanks!

Comment 19

[Jonathan Almeida [:jonalmeida]]

I think for telemetry plumbing, we don't need verification. I can see data start to flow in already from those probes in this graph: https://sql.telemetry.mozilla.org/dashboard/fenix-vpn-telemetry?p_channel=beta

Thank you!