2061081 - [css-typed-arithmetic] Fix parsing of line-height <number> values that use percentages

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sajid Anwar [:sajidanwar]]

In the typed arithmetic patch in Bug 1827404, there were three failing cases in typed_arithmetic.html related to line-height. From my comment:

There are 3 failing tests that all have used-value-equivalent to 1 in the name. These are tests that use percentages in line-height but which used typed arithmetic to construct a <number> instead of a <length-percentage>. The <number> parser is rejecting percentages even though they should be allowed here. Will need to fix the line-height parsing.

Comment 1

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 2061081 - Properly handle line-height <number> calcs with percentages or lh-lengths. r=#style

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/48206dde565e
https://hg.mozilla.org/integration/autoland/rev/8f2ccb660c40
Properly handle line-height <number> calcs with percentages or lh-lengths. r=firefox-style-system-reviewers,emilio,dshin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a7cba55490b
https://hg.mozilla.org/integration/autoland/rev/0534a06c76fe
Revert "Bug 2061081 - Properly handle line-height <number> calcs with percentages or lh-lengths. r=firefox-style-system-reviewers,emilio,dshin" for causing mass build bustages.

Comment 4

[Iulian Moraru]

Revert for causing mass build bustages.

• Push with failures

• Failure log

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a45395200408
https://hg.mozilla.org/integration/autoland/rev/576a9f6a4d86
Properly handle line-height <number> calcs with percentages or lh-lengths. r=firefox-style-system-reviewers,emilio,dshin

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/576a9f6a4d86

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62320 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot