Closed Bug 2061188 Opened 3 months ago Closed 1 month ago

Route event create/edit through the attribute-driven dialog shell

Categories

(Calendar :: Calendar Frontend, task)

task
Points:
3

Tracking

(Not tracked)

RESOLVED FIXED
159 Branch

People

(Reporter: arschmitz, Assigned: arschmitz)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [calendar-ui-create-edit])

Attachments

(1 external file)

Summary:
Make the normal New Event and Edit Event entry points choose the new attribute-driven create/edit dialog when its rollout preference is enabled. Keep the existing editor and tab-edit behavior intact.

For an edit, the router supplies only stable identity attributes (calendar-id, event-id, and, when applicable, recurrence-id). For a new event, it supplies no edit identity so the dialog starts in create mode. The dialog remains responsible for loading its own source; callers must not pass a preloaded raw calendar item.

Links:

Acceptance criteria:

  • With the new-dialog preference enabled, New Event opens the new create/edit dialog.
  • With the preference enabled, Edit Event opens the new dialog for the selected event or occurrence.
  • Edit routing sets calendar-id and event-id; it adds recurrence-id only for a specific occurrence.
  • Create routing sets none of those edit identity attributes.
  • Routing passes identity only; it does not provide a preloaded calIEvent or another raw item as dialog state.
  • When calendar.item.editInTab applies, existing tab editing remains available.
  • With the new-dialog preference disabled, existing legacy-dialog behavior remains available.
  • Tasks and todos do not use the event create/edit dialog.
  • Automated coverage verifies pref-on and pref-off create/edit paths, identity attributes, create mode, tab editing, legacy fallback, and task/todo exclusion. Browser dialog-launch coverage runs axe where supported.

Out of scope:

  • The Redux source loader itself remains Bug 2061191.
  • The read-dialog Edit control and its routing remain Bugs 2070101 and 2020692.
  • This story only owns normal create/edit command routing.
Blocks: 2062086
Blocks: 2062087
Blocks: 2020692
Points: --- → 3
Assignee: nobody → arschmitz
Blocks: 2070402
No longer blocks: 2070402
Blocks: 2072248
No longer blocks: 2072248
Blocks: 2072248

TB-Tools-Id: 17fbc6ce-509c-4945-9dbf-bde0808fa046

Target Milestone: --- → 159 Branch

Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/d506943ed6c9
Implement preference and routing to new calendar dialog. r=klamping

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Type: enhancement → task
Blocks: 2080883
No longer blocks: 2080883
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: