Route event create/edit through the attribute-driven dialog shell
Categories
(Calendar :: Calendar Frontend, task)
Tracking
(Not tracked)
People
(Reporter: arschmitz, Assigned: arschmitz)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [calendar-ui-create-edit])
Attachments
(1 external file)
Summary:
Make the normal New Event and Edit Event entry points choose the new attribute-driven create/edit dialog when its rollout preference is enabled. Keep the existing editor and tab-edit behavior intact.
For an edit, the router supplies only stable identity attributes (calendar-id, event-id, and, when applicable, recurrence-id). For a new event, it supplies no edit identity so the dialog starts in create mode. The dialog remains responsible for loading its own source; callers must not pass a preloaded raw calendar item.
Links:
- SOW: In Scope: https://docs.google.com/document/d/1ZVLX8VjxaYsSBuywLyFsXf27Q-Pf55g8QxT8G9z0eZ4/edit?tab=t.0#heading=h.bz8l40hwl6cr
- SOW: Objective/front-end-only scope: https://docs.google.com/document/d/1ZVLX8VjxaYsSBuywLyFsXf27Q-Pf55g8QxT8G9z0eZ4/edit?tab=t.0#heading=h.2yd4s6tah866
- Zeplin main create/edit entry target: https://app.zeplin.io/project/66dd0f2b2fe8f1b63cda36f1/screen/6a0f2f285393a283202254bc
- Planning: Redux - State Ownership
- Planning: Questions - Q03 Feature Pref Semantics And Rollout
Acceptance criteria:
- With the new-dialog preference enabled, New Event opens the new create/edit dialog.
- With the preference enabled, Edit Event opens the new dialog for the selected event or occurrence.
- Edit routing sets
calendar-idandevent-id; it addsrecurrence-idonly for a specific occurrence. - Create routing sets none of those edit identity attributes.
- Routing passes identity only; it does not provide a preloaded
calIEventor another raw item as dialog state. - When
calendar.item.editInTabapplies, existing tab editing remains available. - With the new-dialog preference disabled, existing legacy-dialog behavior remains available.
- Tasks and todos do not use the event create/edit dialog.
- Automated coverage verifies pref-on and pref-off create/edit paths, identity attributes, create mode, tab editing, legacy fallback, and task/todo exclusion. Browser dialog-launch coverage runs axe where supported.
Out of scope:
- The Redux source loader itself remains Bug 2061191.
- The read-dialog Edit control and its routing remain Bugs 2070101 and 2020692.
- This story only owns normal create/edit command routing.
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
TB-Tools-Id: 17fbc6ce-509c-4945-9dbf-bde0808fa046
| Assignee | ||
Updated•1 month ago
|
Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/d506943ed6c9
Implement preference and routing to new calendar dialog. r=klamping
| Assignee | ||
Updated•1 month ago
|
Description
•