2061208 - Crash in [@ ExchangeMessageCopyHandler::OnCreateFinished]

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect)

Description

[Wayne Mery (:wsmwk)]

New crash, for all flavors of version 153.

User comment "cant send email" - Crash report: https://crash-stats.mozilla.org/report/index/e0d08baf-3f1a-4d88-b8b8-362610260728

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  ExchangeMessageCopyHandler::OnCreateFinished(nsresult, nsIMsgDBHdr*)  mailnews/protocols/exchange/src/ExchangeMessageCopyHandler.cpp:240
1  xul.dll  std::_Func_class<void, nsresult, nsIMsgDBHdr*>::operator()(nsresult, nsIMsgDB...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.50.35717/include/functional:930
2  xul.dll  MessageCreateHandler::OnRemoteCreateFinished(nsresult, nsTSubstring<char> con...  mailnews/protocols/exchange/src/ExchangeMessageCreate.cpp:97
3  xul.dll  xpcom::refptr::impl$1::deref(xpcom::refptr::RefPtr<xpcom::interfaces::idl::IE...  dist/xpcrs/rt/IExchangeClient.rs:1375
3  xul.dll  protocol_shared::safe_xpcom::SafeListenerWrapper<xpcom::interfaces::idl::IExc...  rust/protocol_shared/src/safe_xpcom/message_create_listener.rs:24
3  xul.dll  protocol_shared::safe_xpcom::message_create_listener::impl$1::on_failure(prot...  rust/protocol_shared/src/safe_xpcom/message_create_listener.rs:42
3  xul.dll  protocol_shared::safe_xpcom::handle_error(protocol_shared::safe_xpcom::SafeLi...  rust/protocol_shared/src/safe_xpcom.rs:105
3  xul.dll  protocol_shared::client::DoOperation::handle_operation::async_fn$0(core::pin:...  rust/protocol_shared/src/client.rs:67
3  xul.dll  ews_xpcom::client::create_message::impl$1::create_message::async_fn$0(core::p...  rust/ews_xpcom/src/client/create_message.rs:140
3  xul.dll  async_task::runnable::spawn_local::impl$1::poll(core::pin::Pin<ref_mut$<async...  third_party/rust/async-task/src/runnable.rs:132

Comment 1

[Eleanor Dicharry]

Attachment: Bug 2061208 - Guard against missing message on sent message create failure. r=#thunderbird-back-end-reviewers

Comment 2

[Eleanor Dicharry]

Looks like this was caused by improper handling of a server error when saving a sent message.

Comment 3

[Eleanor Dicharry]

Comment on attachment 9622542 [details]
Bug 2061208 - Guard against missing message on sent message create failure. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: In the case where a user sends a message and the server errors while saving to the sent folder, this fix fixes a crash.
• User impact if declined: When a server error is encountered during the sent message save process, Thunderbird will crash.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: No
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This guards against accessing a pointer in an error case.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 4

[Corey Bryant]

Comment on attachment 9622542 [details]
Bug 2061208 - Guard against missing message on sent message create failure. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for beta
Approved for release
Approved for esr153

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a8f4834b41b8
Guard against missing message on sent message create failure. r=jtracey

Comment 6

[Evandro Baginski [:ebaginski]]

Thunderbird ESR153
https://hg.mozilla.org/releases/comm-esr153/rev/0689e670ee37

Comment 7

[Stephen King (:sking)]

Thunderbird 153.0.3:
https://hg.mozilla.org/releases/comm-release/rev/629bafd8b5fa

Comment 8

[Stephen King (:sking)]

Thunderbird 154.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f0c7a2319ef7