Open Bug 2061580 Opened 3 months ago Updated 1 month ago

Implement recurrence row and basic Add/Remove behavior

Categories

(Calendar :: Calendar Frontend, task)

task

Tracking

(Not tracked)

People

(Reporter: arschmitz, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [calendar-ui-create-edit])

Summary:
Add the main dialog's controls for making an event repeat. Add recurrence
starts a weekly rule when no rule is retained. Remove recurrence turns Repeat
off and keeps that rule. The row also opens
the Repeat view for further editing.

These actions change the draft, which holds unsaved values. They do not change
the saved event.

Links:

Acceptance criteria:

  • Show the recurrence entry as designed in Zeplin.
  • A new event starts with Repeat off. An existing event shows the repeat rule
    from its accepted loaded data. Show the row for an event in a repeating series.
  • Add recurrence turns Repeat on. Reuse a retained rule if one exists. Otherwise,
    create a weekly rule using the draft's selected start day and time. Then offer
    Remove recurrence.
  • Remove recurrence marks Repeat as disabled and returns the row to its
    non-repeating state. Keep the rule in both the draft and its input controls.
    Adding recurrence again restores that rule.
  • Opening the recurrence entry asks the dialog to show the Repeat view and
    preserves the current draft.
  • Apply initial row state before positioning. Later Add/Remove actions follow
    existing layout and overflow rules without unexpected outer-dialog growth.
  • If the dialog switches from A to B, an old Add, Remove, or navigation action
    for A must not change B's draft or view.
  • Add/Remove and ordinary input leave the source event unchanged until Save.

Required implementation details:

  • Render through stable storeObserver selections for the current session,
    which identifies one create or edit operation. Do not add store-reading getters.

  • Send typed updates for the recurrence section only. Store a plain,
    serializable rule, not calIRecurrenceInfo, live recurrence-rule objects,
    calIEvent, input elements, or editor objects.

  • Check the current session before accepting actions.

  • The field-owned serialization helper converts a valid draft rule to Calendar
    recurrence objects only within the Save transaction.

  • Request Repeat navigation through the dialog controller. Bug 2062000 builds
    that view; this row does not build it.

  • Use the row enabled state added in Bug 2061214. Save excludes a disabled
    repeat rule. Edit Save removes the old recurrence from the saved event,
    without clearing the retained draft rule or input values.

Minimum test coverage:

  • Check new non-repeating events and existing repeating events.

  • Check the weekly default uses the selected start day and time.

  • Check Add/Remove change only the recurrence draft and not the source event.

  • Check plain data in Redux and actions, with no live platform objects.

  • Check Repeat navigation preserves the draft.

  • Check initial readiness and later layout behavior.

  • Switch A to B and check that old Add, Remove, and navigation actions do nothing.

  • Run axe checks on displayed recurrence-row states where supported.

  • Remove and add recurrence after editing a rule. Check that the rule and
    input values survive. Save with Repeat off must create no repeat rule and
    must remove existing recurrence on edit. Failed Save must keep row state
    and the retained rule.

Out of scope:

  • Repeat view layout, preset choices, and custom rule editing.
  • Prompts to choose which occurrences to change.
  • Direct recurrence API changes, Save transactions, and saving events.
Blocks: 2061581
Summary: Implement repeat row and repeat subview shell → Implement recurrence row and basic Add/Remove behavior
Blocks: 2062000
No longer blocks: 2061581
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.