Open Bug 2061666 Opened 1 day ago

sync-manager not quite as thread safe as expected

Categories

(Application Services :: Sync, defect, P3)

Product:
Application Services
Component:
Sync
Type:
defect

Tracking

(Not tracked)

People

(Reporter: markh, Unassigned)

Details

I believe that when syncing, the sync-manager takes a lock - but the disconnect(), wipe(), reset() and reset_all() methods don't acquire it. There's a chance of data races if a sync is happening when these are called - eg, reset() wipes last-sync metadata, a sync finishing might add it back.

Seems unlikely in practice, but we should try and clean this up - are they all even called?

You need to log in before you can comment on or make changes to this bug.