Improve diagnostics for gray marking failures
Categories
(Core :: JavaScript: GC, task, P3)
Tracking
()
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(4 external files)
Currently when AssertCellIsNotGray fails we get a single assertion failure with no other information. This isn't terrible helpful when tracking down problems.
| Assignee | ||
Comment 1•3 months ago
|
||
This changes the gray marking checks to print all cells that were found to be
gray (rather than stopping at the first one) and then running a gray marking check
over the whole heap at the end of GC if any were found (and if it is compiled in).
It also adds some extra details like trace kind and zone GC state to the output.
Updated•3 months ago
|
| Assignee | ||
Comment 2•3 months ago
|
||
We sometimes get the same cell recorded multiple times in the buffer, so add a
check against the last element to help mitigate this.
The buffer doesn't seem to grow particularly large in actual use (the largest I
saw was ~100 elements) so it's probably not worth makin this more complicated
by using a hash table.
Updated•3 months ago
|
Comment 4•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/47ff9049790a
https://hg.mozilla.org/mozilla-central/rev/86c18715db77
| Assignee | ||
Comment 6•24 days ago
|
||
This changes the gray marking checks to print all cells that were found to be
gray (rather than stopping at the first one) and then running a gray marking check
over the whole heap at the end of GC if any were found (and if it is compiled in).
It also adds some extra details like trace kind and zone GC state to the output.
Updated•24 days ago
|
| Assignee | ||
Comment 7•24 days ago
|
||
We sometimes get the same cell recorded multiple times in the buffer, so add a
check against the last element to help mitigate this.
The buffer doesn't seem to grow particularly large in actual use (the largest I
saw was ~100 elements) so it's probably not worth makin this more complicated
by using a hash table.
Updated•24 days ago
|
Comment 8•24 days ago
|
||
firefox-esr153 Uplift Approval Request
- User impact if declined/Reason for urgency: Required for uplift of bug 2075296 which fixes multiple security vulnerabilities.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: This is a change to gray marking diagnostics only. It's been on central for two months. There is one regression but it only affects debug builds and has no user impact.
- String changes made/needed?: None
- Is Android affected?: yes
Updated•24 days ago
|
Updated•24 days ago
|
Updated•24 days ago
|
Updated•14 days ago
|
Description
•