Closed Bug 2061758 Opened 3 months ago Closed 3 months ago

Improve diagnostics for gray marking failures

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox-esr153 --- fixed
firefox155 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(4 external files)

Currently when AssertCellIsNotGray fails we get a single assertion failure with no other information. This isn't terrible helpful when tracking down problems.

This changes the gray marking checks to print all cells that were found to be
gray (rather than stopping at the first one) and then running a gray marking check
over the whole heap at the end of GC if any were found (and if it is compiled in).

It also adds some extra details like trace kind and zone GC state to the output.

Attachment #9624109 - Attachment description: Bug 2061758 - Run heap check if gray marking assertions fail to give more information r?#spidermonkey-reviewers → Bug 2061758 - Part 1: Run heap check if gray marking assertions fail to give more information r?#spidermonkey-reviewers

We sometimes get the same cell recorded multiple times in the buffer, so add a
check against the last element to help mitigate this.

The buffer doesn't seem to grow particularly large in actual use (the largest I
saw was ~100 elements) so it's probably not worth makin this more complicated
by using a hash table.

Attachment #9624712 - Attachment description: WIP: Bug 2061758 - Part 2: Try to skip recording duplicate elements in the buffer r#spidermonkey-reviewers → Bug 2061758 - Part 2: Try to skip recording duplicate elements in the buffer r?#spidermonkey-reviewers
Pushed by jcoppeard@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/71d5988e4d1f https://hg.mozilla.org/integration/autoland/rev/47ff9049790a Part 1: Run heap check if gray marking assertions fail to give more information r=spidermonkey-reviewers,sfink https://github.com/mozilla-firefox/firefox/commit/124287f870cd https://hg.mozilla.org/integration/autoland/rev/86c18715db77 Part 2: Try to skip recording duplicate elements in the buffer r=spidermonkey-reviewers,sfink
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Regressions: 2068387

Adding dependency for uplift to ESR153.

Depends on: 2045112

This changes the gray marking checks to print all cells that were found to be
gray (rather than stopping at the first one) and then running a gray marking check
over the whole heap at the end of GC if any were found (and if it is compiled in).

It also adds some extra details like trace kind and zone GC state to the output.

Attachment #9668086 - Flags: approval-mozilla-esr153?

We sometimes get the same cell recorded multiple times in the buffer, so add a
check against the last element to help mitigate this.

The buffer doesn't seem to grow particularly large in actual use (the largest I
saw was ~100 elements) so it's probably not worth makin this more complicated
by using a hash table.

Attachment #9668087 - Flags: approval-mozilla-esr153?

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: Required for uplift of bug 2075296 which fixes multiple security vulnerabilities.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is a change to gray marking diagnostics only. It's been on central for two months. There is one regression but it only affects debug builds and has no user impact.
  • String changes made/needed?: None
  • Is Android affected?: yes
Blocks: 2076903
Attachment #9668086 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
Attachment #9668087 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: