2061927 - nvidia RTX HDR Video playback displays an error.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[junjun]

Attachment: error.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:154.0) Gecko/20100101 Firefox/154.0

Steps to reproduce:

System HDR: On
NVIDIA RTX HDR: On
gfx.webrender.overlay-vp-auto-hdr :true
play https://cf.lv.game.qq.com/dis_kt_c0a2691725e7f33165c79286413694b3_1785838354/0b53yqalkaaabiaa7m3r2bvoprgdwxcabnia.f0.mp4

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Ashley Hale [:ahale]]

I assume this is specific to NVIDIA's SDR to HDR video playback feature from the description - Sotaro do you mind taking a look at this?

Comment 3

[Sotaro Ikeda [:sotaro]]

junjun, can you attach about support to this bug?

Comment 4

[junjun]

Attachment: about-support.txt

Comment 5

[junjun]

I found that I couldn't reproduce the issue using the video link provided above.

This Google Drive folder contains a backup of the video that demonstrates the error.
https://drive.google.com/file/d/15ltrNx3w7SP8YUOOqdigURDYw2TCWFK5/view?usp=drive_link

Comment 6

[Sotaro Ikeda [:sotaro]]

junjun, can you check if the problem happens with chrome browser?

Comment 7

[junjun]

Attachment: compare.png

Play local files using two browsers.

Comment 8

[Sotaro Ikeda [:sotaro]]

https://drive.google.com/file/d/15ltrNx3w7SP8YUOOqdigURDYw2TCWFK5/view?usp=drive_link

I seems to see a different symptom than comment 7 with Firefox 159. Playback a down loaded file from the link looked darker than the playback from the link.

Comment 9

[Sotaro Ikeda [:sotaro]]

I compared the following 2 videos.

• [1] playback from link
• [2] playback from down loaded file.

SurfaceFormat of [1] was gfx::SurfaceFormat::NV12
SurfaceFormat of [2] was gfx::SurfaceFormat::P010

But [2] video was handled as non-HDR by DCSurfaceVideo::AttachExternalImage(). Then [2] applies super resolution. It is decided in DCSurfaceVideo::AttachExternalImage().

From the symptom, some NVIDIA GPU could not apply super resolution to non-NV12 video frame.

Original implementation did not apply super resolution to P010. But it was changed by Bug 2030296.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2061927 - Limit VpAutoHDR only to NV12

Comment 11

[Sotaro Ikeda [:sotaro]]

It seems that some GPU driver does not support VpAutoHDR with P010 format video with R16G16B16A16 SwapChain. Then it seems better to use R10G10B10A2 swap chain instead.

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2061927 - Use R10G10B10A2 for video swap chain of VpAutoHDR

Comment 13

[Sotaro Ikeda [:sotaro]]

junjun, can you test if the problem is addressed with the following build? The build is "public/build/target.zip".

https://firefox-ci-tc.services.mozilla.com/tasks/CCHDugxDTZy-NaR2n2RC3A#artifacts
https://treeherder.mozilla.org/jobs?repo=try&revision=3d6b82eaf0551d10c7ccda39c9a3b0c89af5d4a1

Comment 14

[Sotaro Ikeda [:sotaro]]

chromium choose swap chain's color space of VpAutoHDR as DXGI_COLOR_SPACE_RGB_FULL_G2084_NONE_P2020 in SwapChainPresenter::VideoProcessorBlt().

Comment 15

[junjun]

(In reply to Sotaro Ikeda [:sotaro] from comment #13)

junjun, can you test if the problem is addressed with the following build? The build is "public/build/target.zip".

https://firefox-ci-tc.services.mozilla.com/tasks/CCHDugxDTZy-NaR2n2RC3A#artifacts
https://treeherder.mozilla.org/jobs?repo=try&revision=3d6b82eaf0551d10c7ccda39c9a3b0c89af5d4a1

I downloaded and used public/build/target.zip.

The video playback displays correctly.
However, I noticed that videos from any website no longer support the NVIDIA RTX Video features.

With the official release version, simply turning off RTX HDR allows the video to display correctly.

Comment 16

[Sotaro Ikeda [:sotaro]]

Thank you for checking. Sorry, I also confirmed the above build binary did not use VpAutoHDR. I did not check it. Sorry. My local build worked well. Then I am going to look into why it happened.

Comment 17

[Sotaro Ikeda [:sotaro]]

I checked "public/build/target.zip" of comment 13.

From Firefox profiler, driver says that driver does not support VpAutoHDR. Then somehow, NVIDIA driver does not enable VpAutoHDR for CI built Firefox binary.

---

DCSurfaceVideo - useVpAutoHDR 0 gfxVars 1 contentIsHDR 0 monitor 1 driver 0 charging 1 failed 0

https://share.firefox.dev/3T3mapS

https://searchfox.org/firefox-main/rev/9c0ad0c9084ef0e36d29aae83892ea4edf3c9085/gfx/webrender_bindings/DCLayerTree.cpp#2341

Comment 18

[Sotaro Ikeda [:sotaro]]

I confirmed that the problem was addressed with my local build, then it seems better to progress the patch review for now.

Comment 19

[Sotaro Ikeda [:sotaro]]

Created Bug 2075830 for comment 17.

Comment 20

[Sotaro Ikeda [:sotaro]]

Somehow with latest m-c CI build, "public/build/target.zip" used VpAutoHDR with my PC with NVIDIA GPU for me.

https://firefox-ci-tc.services.mozilla.com/tasks/Q5GQX63XRkukWn5pEZ2ATw#artifacts
https://treeherder.mozilla.org/jobs?repo=try&revision=34d3d2fd73f2dc437d524584a221200b584c943b

Comment 21

[Sotaro Ikeda [:sotaro]]

junjun, can you test if "public/build/target.zip" of comment 20 addresses VpAutoHDR usage problem for you?

Comment 22

[junjun]

(In reply to Sotaro Ikeda [:sotaro] from comment #20)

Somehow with latest m-c CI build, "public/build/target.zip" used VpAutoHDR with my PC with NVIDIA GPU for me.

https://firefox-ci-tc.services.mozilla.com/tasks/Q5GQX63XRkukWn5pEZ2ATw#artifacts
https://treeherder.mozilla.org/jobs?repo=try&revision=34d3d2fd73f2dc437d524584a221200b584c943b

Using this version, RTX VSR and HDR functions work correctly.
There are no errors in the video image.

Comment 23

[Sotaro Ikeda [:sotaro]]

Great! Thank you for the checking.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37f1f666232b
https://hg.mozilla.org/integration/autoland/rev/7697918c5eb1
Use R10G10B10A2 for video swap chain of VpAutoHDR r=gfx-reviewers,ahale,lsalzman

Comment 25

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7697918c5eb1

Comment 26

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2030296

Comment 27

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected, along with ESR.

:sotaro, please make an uplift decision for beta and ESR:

• For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox158 to wontfix if the fix can wait for the next release.
• For ESR, nominate the patch for the appropriate ESR uplift approval if the fix should be included in ESR, or set the ESR status flag(s) to wontfix if an uplift isn't needed. Each affected ESR release needs a decision.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Fx159 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Fixed some videos displaying incorrectly on Windows when NVIDIA RTX Video HDR is enabled.

Comment 29

[Sotaro Ikeda [:sotaro]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Without the fix, some videos rendering color are incorrect when NVIDIA RTX Video HDR is enabled.
[Affects Firefox for Android]: No
[Suggested wording]: Fixed some videos displaying incorrectly on Windows when NVIDIA RTX Video HDR is enabled.
[Links (documentation, blog post, etc)]: None

Comment 30

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx159 relnotes.