Closed Bug 2062679 Opened 18 days ago Closed 10 days ago

[BHR] Point the BHR aggregation job at the redacted hang_report view

Categories

(Core :: XPCOM, task)

task

Tracking

()

RESOLVED FIXED
156 Branch
Tracking Status
firefox156 --- fixed

People

(Reporter: sning, Assigned: sning)

References

Details

(Whiteboard: [bhr-dashboard-v1])

Attachments

(1 file)

The BHR aggregation cron (bug 2048276) reads BigQuery as hang-report-collection@mozdata.iam.gserviceaccount.com, granted on firefox_desktop.hang_report. That view carries far more than the job reads: session id, geo, ISP, attribution, experiments, user-agent data and IP-derived metadata.

DENG-11394 adds firefox_desktop.hang_report_redacted, a narrow allow-list projection exposing only the seven columns the query selects. bigquery-etl PR: https://github.com/mozilla/bigquery-etl/pull/9778

This bug repoints _BQ_TABLE at the redacted view. Sequencing:

  1. bigquery-etl #9778 merges and deploys (adds the view + grant)
  2. this bug lands (repoints the job)
  3. follow-up bigquery-etl PR revokes workgroup_access on hang_report

Step 3 cannot precede step 2 or the running cron breaks

The aggregation job's service account is granted on
firefox_desktop.hang_report, which carries far more than the job reads:
session id, geo, ISP, attribution, experiments, user-agent data and
IP-derived metadata.

firefox_desktop.hang_report_redacted (DENG-11394, bigquery-etl #9778) is a
narrow allow-list projection of the same stable table exposing only the
columns this query selects. Point the job at it so the wide grant can be
revoked.

No data change: the generated hang_report view is SELECT * plus derived
columns (app_version_*, is_bot_generated) and filters no rows, so every
column read here is identical through either view.

Landing order: the view must be deployed before this lands, and the grant on
firefox_desktop.hang_report is only revoked afterwards. Revoking before this
lands would break the running cron.

Attachment #9625836 - Attachment description: WIP: Bug 2062679 - Read BHR pings from the redacted hang_report view r?dthayer → Bug 2062679 - Read BHR pings from the redacted hang_report view r?dthayer
Status: NEW → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: