206268 - Clicking Go button with a bookmark keyword expression in URL/location bar does search instead

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[paxunix]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030509 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030517 Mozilla Firebird/0.6

You need at least one bookmark with a keyword and the Go button must exist on
your button toolbar to verify this.  Type in your bookmark keyword expression in
the URL/location bar and instead of hitting Enter, click the Go button.  Instead
of evaluating your bookmark keyword string, your typed text is sent off to your
default search engine.

Reproducible: Always

Steps to Reproduce:



Expected Results:  
Bookmark keyword expression should be evaluated as though Enter had been
pressed.  It is important that the fix for this does not break middle-click on
the Go button (which, if you have things configured that way, would evaluate
your bookmark keyword expression in a new tab).

Comment 1

[Erik]

Confirming this one using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030519 Mozilla Firebird/0.6

=> changing to "NEW" since I didn't found a related bug already filed for this
problem. Maybe also a toolbar issue?

Comment 2

[paxunix]

Attachment: Fix go-button oncommand handler to call correct function

This patch changes the go-button oncommand handler to act like the textentered
handler for the urlbar.  Note that this does not yet mean you can hold Alt and
click the Go button to have the entered URL loaded in a new tab (it doesn't
work like that right now anyway).

It does mean if you type a bookmark keyword expression in the URL bar and click
Go, it Does The Right Thing.

Could use an r,sr...

Comment 3

[noririty]

Comment on attachment 124659 [details] [diff] [review]
Fix go-button oncommand handler to call correct function

fix landed