2062695 - [Models] Improve Clustering for ATG

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Vasish Baungally]

Need to think about improvements (e.g. using the LLM possibly for grouping)

Comment 1

[Vasish Baungally]

Attachment: Bug 2062695 - Improve Precision for Clusters for Auto Tab Grouping. r?jlewis,rrando

This patch adds the missed tab title preprocessin that was present in Smart Tab Grouping.
It also reduces false positives in clusters so groups have higher cohesion.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/284be2745072
https://hg.mozilla.org/integration/autoland/rev/d03c49a02c94
Improve Precision for Clusters for Auto Tab Grouping. r=jlewis,tabbrowser-reviewers,dao

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d03c49a02c94

Comment 4

[Rares Doghi, Desktop QA]

This is a hard thing to verify but from what I noticed, even with tabs from the same domain, Organize tabs will show separate Tab groups more specific to those pages. Verified as fixed in our latest Nightly 156.0a1 (2026-08-19)

Comment 5

[Vasish Baungally]

Attachment: Bug 2062695 - Improve Precision for Clusters for Auto Tab Grouping.

This patch adds the missed tab title preprocessing that was present in Smart Tab Grouping.
It also reduces false positives in clusters so groups have higher cohesion.

Original Revision: https://phabricator.services.mozilla.com/D319192

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: There are two features in Auto Tab Grouping for Smart Window - clustering / creating groups and naming the groups.

We have received feedback from Foxfooding that both could use improvements.

This patch improves the clustering portion of ATG. It creates more topically similar groups and ensures that they are more precise.

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Open a couple of tabs that are related (e.g. this bug and its patch) and enable smart window. Click on the "window type" icon that shows up on the top right bar. This should show a group name along with the two related tabs.
• Risk associated with taking this patch: low
• Explanation of risk level: It's just config changes and a small text preprocessing update.
• String changes made/needed?: No
• Is Android affected?: no

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: There are two features in Auto Tab Grouping for Smart Window - clustering / creating groups and naming the groups.

We have received feedback from Foxfooding that both could use improvements.

This patch improves the clustering portion of ATG. It creates more topically similar groups and ensures that they are more precise.

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Open a couple of tabs that are related (e.g. this bug and its patch) and enable smart window. Click on the "window type" icon that shows up on the top right bar. This should show a group name along with the two related tabs.
• Risk associated with taking this patch: low
• Explanation of risk level: It's just config changes and a small text preprocessing update.
• String changes made/needed?: No
• Is Android affected?: no

Comment 8

[Vasish Baungally]

Attachment: Bug 2062695 - Improve Precision for Clusters for Auto Tab Grouping.

This patch adds the missed tab title preprocessing that was present in Smart Tab Grouping.
It also reduces false positives in clusters so groups have higher cohesion.

Original Revision: https://phabricator.services.mozilla.com/D319192

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Phabricator Automation from comment #7)

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: There are two features in Auto Tab Grouping for Smart Window - clustering / creating groups and naming the groups.

We have received feedback from Foxfooding that both could use improvements.

This patch improves the clustering portion of ATG. It creates more topically similar groups and ensures that they are more precise.

This doesn't really answer the "Why now?" aspect of the question. We're rolling out shortened release cycles with one specific goal of cutting down on the number of feature uplifts going into Beta and especially dot releases. This has had basically no Nightly bake time and we're already only a week away from 155 going to RC, so IMO this should ride the 156 release shipping on 15-Sep. If there's a hard product need for it to ship earlier than that, then the case for that needs to be spelled out more clearly.

Comment 10

[Vasish Baungally]

There is a product requirement unfortunately. This feature is being tied to 154 dot release for which there is telemetry going on and there's a decision to stop development if the success criteria isn't met. Without this patch and the one that improves naming (https://phabricator.services.mozilla.com/D319836), the success criteria (85% tabs being approved) is unlikely to be met.

If it's too tight a deadline, that's ok. I'll bring this up with the product folks.

Comment 11

[Vasish Baungally]

Discussed with product, ok for 155 beta, no release uplift.

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/57403817207e
https://hg.mozilla.org/releases/mozilla-beta/rev/74c512080546

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 155.0b3