2062710 - [Nova] CHROME_MINIMAL_POPUP url bar window colours are inconsistent

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Attachment: Vertical Tabs Standard.png

STR: Enable nova, and open a pop-up window, then toggle between vertical tabs and non-vertical tabs

ER: The colour styling of CHROME_MINIMAL_POPUP windows remains consistent, and is consistent with the rest of the browser.

AR:

1. The titlebar section is a native OS titlebar, whereas normal browser windows use Firefox theme colours (i.e. the gradient) for the titlebar section with window controls (usually the tab strip is embedded here)
2. When vertical tabs are enabled, the URL bar uses the theme gradient, and when vertical tabs are disabled, it uses a gray background. This should probably be consistent as there is no tab strip for these windows.

---

Opinion Time: Overall the behaviour I personally would expect from a CHROME_MINIMAL_POPUP window like this effectively the UX of a "compact" horizontal tabs window, with the tab strip hidden, and replaced with the window title. This would have the gradient across the window control area like it is for normal windows, and would be compact in-line with the "minimal popup" goals.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Horizontal Tabs Standard.png

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Vertical Tabs Compact.png

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Horizontal Tabs Compact.png

Comment 4

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Jules Simplicio [:jules]]

We believe this is pre-existing Nova. Depending on if you're in horizontal / vertical mode. The Toolbar will take in the Tabstrip color in vertical mode.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

It seems like this was recently fixed, perhaps by bug 2062351 or bug 2063294. The URL bar now always is consistently gray coloured both with vertical tabs enabled and disabled.

These windows don't have a coloured titlebar, but I think that is expected behaviour as it's a native OS titlebar.