Closed Bug 2063233 Opened 1 month ago Closed 1 month ago

[Nova] Double line displayed between Account and Secure Sync on the Account menu

Categories

(Firefox :: Menus, defect, P1)

Firefox 155
Desktop
All
defect
Points:
2

Tracking

()

VERIFIED FIXED
156 Branch
Tracking Status
firefox155 --- verified
firefox156 --- verified

People

(Reporter: bcaliman, Assigned: sclements)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-post-nova])

Attachments

(3 files)

Found in

  • Nightly 155

Affected versions

  • Nightly 155

Tested platforms

  • Affected platforms: Windows 11, MacOS, Ubuntu 26

Preconditions

  • have Nightly 155 with Build ID 20260812093659 or later installed
  • be logged in with a FX account

Steps to reproduce

  1. Click on the Application menu.
  2. Click on the account option.
  3. Check the UI of the Account menu.

Expected result

  • The Account and Sync sections are separated by one single line, as displayed in the following Figma specification.

Actual result

  • The Account and Sync sections are separated by double line.

Regression range

  • The issue does not seem to be a regression.
QA Whiteboard: [qa-found-in-c155][QA-5204]

Given the position of the double separator, I'm guessing that the profile-related menu items are being hidden in this view but the additional separator is not being hidden.

Severity: -- → S4
Points: --- → 1
Component: Sidebar → Menus
Priority: -- → P3
Whiteboard: [fidefe-post-nova]
Priority: P3 → P1
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Points: 1 → 2
Pushed by sclements@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c049862ffe55 https://hg.mozilla.org/integration/autoland/rev/2f352f2f5911 Fix double line in account section of app menu r=nsharpley,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(sclements)
  • Update profiles divider, creating a new function to show and hide all relevant elements
  • Update styling and test coverage

Original Revision: https://phabricator.services.mozilla.com/D319480

Attachment #9629264 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Very visible bug in the application menu
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: See the description from QA.
  • Risk associated with taking this patch: low
  • Explanation of risk level: The code is limited to the profiles section and its dividers, ensuring all elements are hidden and shown at one time and there is test coverage.
  • String changes made/needed?: No
  • Is Android affected?: no
Flags: qe-verify+

Hello,

I have verified the issue in Nightly 156.0a1 and can confirm that the double line is now replaced by a single line when accessing the Account submenu.

Flags: needinfo?(sclements)
Flags: in-testsuite+
Attachment #9629264 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-found-in-c155][QA-5204] → [qa-found-in-c155][QA-5204][uplift][qa-ver-needed-c156/b155]

Hello,

I have verified the issue in Firefox Beta 155.0b4 (Build ID 20260824090350) and can confirm that the double line is now replaced by a single line when accessing the Account submenu.
Proceeding to mark this ticket as Verified-Fixed.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-found-in-c155][QA-5204][uplift][qa-ver-needed-c156/b155] → [qa-found-in-c155][QA-5204][uplift][qa-ver-done-c156/b155]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: