Allow opening a native-profiling comparison view from PerfCompare
Categories
(Testing :: PerfCompare, enhancement)
Tracking
(Not tracked)
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
649.41 KB,
image/png
|
Details |
In https://github.com/firefox-devtools/profiler/pull/6012 (bug 2047692) I'm working on a view in the profiler that shows a comparison of two profiles, specialized for benchmarks with subtests like speedometer.
When a developer is looking at a PerfCompare that has native-profiling jobs both on the base push and on the new push, they should have a way to get to this profile comparison.
I'm attaching a screenshot of the UI I've been playing with:
- One new button at the end of each row
- If you click it, a dialog opens
- The dialog lists the available profiles and the associated scores and machine names and lets you pick a pair
- Clicking "Open profile comparison" in the dialog opens a comparison: Example
I'm not sure if an extra button is the right way to go. The space is already pretty cramped, and most tests don't have native-profiling variants. Also, they way to detect native-profiling variants is currently based on tags: If there's an etw-profile, perf-profile, simpleperf-profile or samply-profile tag, it's a native-profiling job and we can show the button.
| Assignee | ||
Comment 1•4 days ago
|
||
Description
•