2063599 - Disable ML autofill for release build

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 2063599 - Only enable ML address form field detection on pre-release channels. r=joschmidt

Telemetry on 154 shows a regression in credit card expiry date detection
since ML field detection was enabled for all channels.

Gate the extensions.formautofill.useml default on the update channel so it
stays enabled on Nightly, Dev Edition and Beta, and is disabled on Release
and ESR.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6966d4a93e6
https://hg.mozilla.org/integration/autoland/rev/91b6b986e26c
Only enable ML address form field detection on pre-release channels. r=joschmidt

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 2063599 - Only enable ML address form field detection on pre-release channels.

Telemetry on 154 shows a regression in credit card expiry date detection
since ML field detection was enabled for all channels.

Gate the extensions.formautofill.useml default on the update channel so it
stays enabled on Nightly, Dev Edition and Beta, and is disabled on Release
and ESR.

Original Revision: https://phabricator.services.mozilla.com/D318986

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: When filling a saved credit card, Firefox often fails to recognize the expiry date fields, so it leaves them blank and the user has to enter the month and year manually. Telemetry shows credit card expiry date detection down ~50% (https://sql.telemetry.mozilla.org/queries/124902/source?p_category=credit-card-expiry&p_channel=beta#302696).
  Also the overall autofill rate down from 42% to 37% (https://sql.telemetry.mozilla.org/queries/123218/source#299530).
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: A single pref default, with no logic change. With the pref off, form field detection falls back to the regex heuristics that shipped in every release before 154.
• String changes made/needed?: None
• Is Android affected?: no

Comment 5

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: When filling a saved credit card, Firefox often fails to recognize the expiry date fields, so it leaves them blank and the user has to enter the month and year manually. Telemetry shows credit card expiry date detection down ~50% (https://sql.telemetry.mozilla.org/queries/124902/source?p_category=credit-card-expiry&p_channel=beta#302696).
  Also the overall autofill rate down from 42% to 37% (https://sql.telemetry.mozilla.org/queries/123218/source#299530).
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: A single pref default, with no logic change. With the pref off, form field detection falls back to the regex heuristics that shipped in every release before 154.
• String changes made/needed?: None
• Is Android affected?: no

Comment 6

[Dimi Lee [:dimi]]

Attachment: Bug 2063599 - Only enable ML address form field detection on pre-release channels.

Telemetry on 154 shows a regression in credit card expiry date detection
since ML field detection was enabled for all channels.

Gate the extensions.formautofill.useml default on the update channel so it
stays enabled on Nightly, Dev Edition and Beta, and is disabled on Release
and ESR.

Original Revision: https://phabricator.services.mozilla.com/D318986

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/91b6b986e26c

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d977cb37d549
https://hg.mozilla.org/releases/mozilla-beta/rev/31085f08b65d

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9114d4f09e81
https://hg.mozilla.org/releases/mozilla-release/rev/a85874f8cc03