Support `flex-wrap: balance` and `flex-line-count` in Stylo
Categories
(Core :: CSS Parsing and Computation, enhancement)
Tracking
()
People
(Reporter: nico, Assigned: nico)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This bug tracks parsing support for the balance keyword of the flex-wrap property and the flex-line-count property.
| Assignee | ||
Comment 1•4 days ago
|
||
Updated•4 days ago
|
Comment 2•1 day ago
|
||
Espresso's closeSoftKeyboard() throws PerformException when the focused view's root is not
the one it expects, which happens whenever no editable view has focus - on the homepage, or
after a dialog takes focus. Hiding the keyboard is only ever a convenience for the assertion
that follows, so failing to do it must not fail the test.
Two tests fail locally on this today, and pass in CI, so it only bites developers running
the suite: SettingsGeneralTest.verifyFontSizingChangeTest via
BasePage.mozVerifyAnyContainsText, and
SettingsSearchTest.verifyCustomSearchEngineCanBeAddedFromSearchEngineMenuTest via
SettingsSearchAddSearchEnginePage.
Adds BasePage.dismissSoftKeyboard(), which wraps the call in runCatching and logs what it
swallowed, and routes the four call sites in the efficiency framework through it. It is
protected rather than private so the two page objects, which extend BasePage, use the same
helper instead of repeating the guard.
A further 13 unguarded calls remain in the legacy ui/robots/* and ui/*Test.kt files. Left
alone here to keep the patch reviewable.
Description
•