2063602 - Support `flex-wrap: balance` and `flex-line-count` in Stylo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Nico Burns]

This bug tracks parsing support for the balance keyword of the flex-wrap property and the flex-line-count property.

See: https://drafts.csswg.org/css-flexbox-2

Comment 1

[Nico Burns]

Attachment: Bug 2063602: Implement `flex-wrap: balance` and `flex-line-count` parsing (Servo-only) (r?#style)

Comment 2

[Jackie Johnson]

Attachment: Bug 2063602 - [efficiency] Do not fail a test when closeSoftKeyboard() cannot hide the keyboard r=isabel_rios,aaronmt

Espresso's closeSoftKeyboard() throws PerformException when the focused view's root is not
the one it expects, which happens whenever no editable view has focus - on the homepage, or
after a dialog takes focus. Hiding the keyboard is only ever a convenience for the assertion
that follows, so failing to do it must not fail the test.

Two tests fail locally on this today, and pass in CI, so it only bites developers running
the suite: SettingsGeneralTest.verifyFontSizingChangeTest via
BasePage.mozVerifyAnyContainsText, and
SettingsSearchTest.verifyCustomSearchEngineCanBeAddedFromSearchEngineMenuTest via
SettingsSearchAddSearchEnginePage.

Adds BasePage.dismissSoftKeyboard(), which wraps the call in runCatching and logs what it
swallowed, and routes the four call sites in the efficiency framework through it. It is
protected rather than private so the two page objects, which extend BasePage, use the same
helper instead of repeating the guard.

A further 13 unguarded calls remain in the legacy ui/robots/* and ui/*Test.kt files. Left
alone here to keep the patch reviewable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b6c7f4fe5c0
https://hg.mozilla.org/integration/autoland/rev/c7062dd0a2d9
[efficiency] Do not fail a test when closeSoftKeyboard() cannot hide the keyboard r=aaronmt

Comment 4

[Jackie Johnson]

hey, sorry all. i entered the wrong bug number in my commit here. hopefully it doesn't mess up any of your work? lmk if it does since i just landed this in autoland. my bad

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1080686d04e8
https://hg.mozilla.org/integration/autoland/rev/e80846c2e67d
Revert "Bug 2063602 - [efficiency] Do not fail a test when closeSoftKeyboard() cannot hide the keyboard r=aaronmt" as requested by @jajohnson for wrongly assigned the bug number.

Comment 6

[Serban Stanca [:SerbanS]]

Reverted this as requested by @jajohnson for wrongly assigned the bug number.

• Revert link

Comment 7

[Phabricator Automation]

Comment on attachment 9627614 [details]
Bug 2063602 - [efficiency] Do not fail a test when closeSoftKeyboard() cannot hide the keyboard r=isabel_rios,aaronmt

Revision D319321 was moved to bug 2064266. Setting attachment 9627614 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ff5db46b553f
https://hg.mozilla.org/integration/autoland/rev/17f42f021079
Implement `flex-wrap: balance` and `flex-line-count` parsing (Servo-only) (r=firefox-style-system-reviewers,emilio,layout-reviewers,dshin)

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/17f42f021079

Comment 10

[Jake Archibald [:jakea]]

I think this is just parsing for now, so doesn't need a dev doc.