2063785 - When anchor has IB-split, anchor() and anchor-size() consider only the first inline fragments

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Testcase #1: inline anchor element with IB-split

Load the attached Testcase #1.

Expected results:
The green rectangle covers all the text. Google Chrome and Safari both have the expected results.

Actual results:
The green rectangle covers only "ipsum dolor".

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2063785 - Union IB-split sibling rects in GetCombinedFragmentRects(). r?#layout

This allows an anchor element that is IB-split to return a correct
union rect so that anchor functions resolve against the anchor's
entire bounding rect, rather than only the first inline fragment.

This patch follows Chrome's and Safari's behavior of unioning the
MozBlockInsideInlineWrapper rects. That is, we do not drill into
the wrapper to find the rects of the real block children.
anchor-position-inline-008.html tests that by adding explicit
width to the block child under anchor.

Note that calling getBoundingClientRect() for inline element that
has IB-split will drill into the block wrapper. This internal
inconsistency is tracked in Bug 2066179.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61f357d29efb
https://hg.mozilla.org/integration/autoland/rev/f9494577f9d6
Union IB-split sibling rects in GetCombinedFragmentRects(). r=layout-reviewers,emilio

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f9494577f9d6

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62318 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot