[wpt-sync] Sync PR 61957 - [Masonry] Implement baseline alignment for subgridded items
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61957 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61957
Details from upstream follow.
Yanling Wang <yanlingwang@microsoft.com> wrote:
[Masonry] Implement baseline alignment for subgridded items
This CL implements baseline alignment for items subgridded into a
grid-lanes container along its grid (subgridded) axis, so they
participate in the container's baseline alignment.Subgridded items are skipped by the container's placement loop because
they are laid out later by their own subgrid, so their baselines are
never gathered there. This CL measures and stores those baselines
separately during the baseline calculation phase, so the subgridded
items are aligned to the container's shared grid-axis baseline.Adds nested subgrids baseline tests, and clears the now-passing entries
from TestExpectations.Bug: 343257585
Change-Id: Ief1de5fbe76aa3a6efd747c7f49f0955de3ff47b
Reviewed-on: https://chromium-review.googlesource.com/8223162
WPT-Export-Revision: 7e7097d3cd9c2f1e3d157a2d5b87b22fd87e9f87
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=39136577bef8b494c7af2bbb5b69c4640f7f9538
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 18 tests
Status Summary
Firefox
FAIL: 4[GitHub] 18[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
PASS: 4
Safari
PASS: 4
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
- /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-nested-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-nested-subgrid-002.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-nested-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-nested-subgrid-002.html [wpt.fyi]:
FAIL
New Tests That Don't Pass
- /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-container-baseline-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-nested-subgrid-001.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-nested-subgrid-002.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-002.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-003.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-004.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-005.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/column-grid-lanes-item-baseline-subgrid-006.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-container-baseline-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-nested-subgrid-001.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-nested-subgrid-002.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-001.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-002.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-003.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-004.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-005.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/subgrid/grid-subgridded-to-grid-lanes/baseline/row-grid-lanes-item-baseline-subgrid-006.html [wpt.fyi]:
FAIL
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/06558c064af9
https://hg.mozilla.org/mozilla-central/rev/0b491109e75c
Description
•