Closed Bug 2063790 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 61957 - [Masonry] Implement baseline alignment for subgridded items

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61957 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61957
Details from upstream follow.

Yanling Wang <yanlingwang@microsoft.com> wrote:

[Masonry] Implement baseline alignment for subgridded items

This CL implements baseline alignment for items subgridded into a
grid-lanes container along its grid (subgridded) axis, so they
participate in the container's baseline alignment.

Subgridded items are skipped by the container's placement loop because
they are laid out later by their own subgrid, so their baselines are
never gathered there. This CL measures and stores those baselines
separately during the baseline calculation phase, so the subgridded
items are aligned to the container's shared grid-axis baseline.

Adds nested subgrids baseline tests, and clears the now-passing entries
from TestExpectations.

Bug: 343257585
Change-Id: Ief1de5fbe76aa3a6efd747c7f49f0955de3ff47b
Reviewed-on: https://chromium-review.googlesource.com/8223162
WPT-Export-Revision: 7e7097d3cd9c2f1e3d157a2d5b87b22fd87e9f87

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 18 tests

Status Summary

Firefox

FAIL: 4[GitHub] 18[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 4

Safari

PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.