Closed Bug 206437 Opened 17 years ago Closed 17 years ago

Mail main window re-sort fails the second time on RTL language

Categories

(Core :: Layout: Text and Fonts, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: akber, Assigned: mkaply)

Details

(Keywords: crash, rtl)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ur-PK; rv:1.3) Gecko/20030313
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ur-PK; rv:1.3) Gecko/20030313

If a RTL language pack is installed, the main window of the mail/newsgroups
works fine, and the RTL shows OK.  If a column (e.g. topic, from, date etc.) is
clicked once - it is still OK - resorting occurs.  On the next resort click -
there is a crash.  I have reproduced it on Win2K, WinXP and Linux with releases
1.2.1 and 1.3x.  I use IMAP email.


Reproducible: Always

Steps to Reproduce:
1.  Install the Urdu langpack
2. Open mail/newsgroups with a valid email account and mail in your mailbox
(IMAP tested)
3. Sort the mail by date or any other column at the top
4. Re-sort 



Expected Results:  
Crash

A few talkback reports were sent.
Confirming in 1.3 with the Urdu langpack. The crash is a stack overflow, and the
stack in talkback TBID is a loop of 
nsTreeColumn::~nsTreeColumn
[c:/builds/seamonkey/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.h]
nsTreeColumn::`scalar deleting destructor' 
Status: UNCONFIRMED → NEW
Ever confirmed: true
I tried to reproduce in current trunk, but unfortunately there is a different
crash there, on the first attempt to sort. I'll file a new bug and make this
depend on it.
Attached patch PatchSplinter Review
No need for a new bug: this patch fixes both crashes. What was happening was
this, at
http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp#3459


 if (normalDirection) {
   // snip left to right case
 }
 else {
   col->SetNext(mColumns);
   mColumns = col;
 }

In some code paths, mColumns has been deleted and not reinitialized when we do
col->SetNext(mColumns).
Attachment #123839 - Flags: superreview?(bryner)
Attachment #123839 - Flags: review?(bryner)
Keywords: crash
Comment on attachment 123839 [details] [diff] [review]
Patch

r/sr=me
Attachment #123839 - Flags: superreview?(bryner)
Attachment #123839 - Flags: superreview+
Attachment #123839 - Flags: review?(bryner)
Attachment #123839 - Flags: review+
Comment on attachment 123839 [details] [diff] [review]
Patch

Requesting 1.4 approval for this simple one line fix. This prevents a crash in
localizations to right-to-left languages (there are already at least 3 of
these, for Hebrew, Urdu and Persian) and should have no side-effects.
Attachment #123839 - Flags: approval1.4?
Comment on attachment 123839 [details] [diff] [review]
Patch

a=mkaply for checkin to 1.4
Attachment #123839 - Flags: approval1.4? → approval1.4+
Fix checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Component: MailNews: BiDi Hebrew & Arabic → Layout: Text
QA Contact: giladehven → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.