206437 - Mail main window re-sort fails the second time on RTL language

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Akber A. Choudhry]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ur-PK; rv:1.3) Gecko/20030313
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ur-PK; rv:1.3) Gecko/20030313

If a RTL language pack is installed, the main window of the mail/newsgroups
works fine, and the RTL shows OK.  If a column (e.g. topic, from, date etc.) is
clicked once - it is still OK - resorting occurs.  On the next resort click -
there is a crash.  I have reproduced it on Win2K, WinXP and Linux with releases
1.2.1 and 1.3x.  I use IMAP email.


Reproducible: Always

Steps to Reproduce:
1.  Install the Urdu langpack
2. Open mail/newsgroups with a valid email account and mail in your mailbox
(IMAP tested)
3. Sort the mail by date or any other column at the top
4. Re-sort 



Expected Results:  
Crash

A few talkback reports were sent.

Comment 1

[Simon Montagu :smontagu]

Confirming in 1.3 with the Urdu langpack. The crash is a stack overflow, and the
stack in talkback TBID is a loop of 
nsTreeColumn::~nsTreeColumn
[c:/builds/seamonkey/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.h]
nsTreeColumn::`scalar deleting destructor' 

Comment 2

[Simon Montagu :smontagu]

I tried to reproduce in current trunk, but unfortunately there is a different
crash there, on the first attempt to sort. I'll file a new bug and make this
depend on it.

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch

No need for a new bug: this patch fixes both crashes. What was happening was
this, at
http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp#3459


 if (normalDirection) {
   // snip left to right case
 }
 else {
   col->SetNext(mColumns);
   mColumns = col;
 }

In some code paths, mColumns has been deleted and not reinitialized when we do
col->SetNext(mColumns).

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 123839 [details] [diff] [review]
Patch

r/sr=me

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 123839 [details] [diff] [review]
Patch

Requesting 1.4 approval for this simple one line fix. This prevents a crash in
localizations to right-to-left languages (there are already at least 3 of
these, for Hebrew, Urdu and Persian) and should have no side-effects.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 123839 [details] [diff] [review]
Patch

a=mkaply for checkin to 1.4

Comment 7

[Simon Montagu :smontagu]

Fix checked in.

Comment 8

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).