Closed Bug 2064559 Opened 3 months ago Closed 1 month ago

Intermittent browser/extensions/newtab/test/browser/browser_newtab_side_by_side_layout.js | single tracking bug

Categories

(Firefox :: New Tab Page, defect, P5)

defect

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: florian)

References

(Blocks 2 open bugs)

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [collect_confirm_failure])

Attachments

(2 external files)

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=586224962&repo=autoland&task=Fzf0AOClRV-9YP68l5h-NA.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Fzf0AOClRV-9YP68l5h-NA/runs/0/artifacts/public/logs/live_backing.log


[task 2026-08-18T22:38:56.507+00:00] 22:38:56     INFO - TEST-PASS | browser/extensions/newtab/test/browser/browser_newtab_side_by_side_layout.js | test_side_by_side_four_column_variant_stops_at_three - Widgets column is still one card wide (width=333.75, expected=333.75) - 0 < 2
[task 2026-08-18T22:38:56.508+00:00] 22:38:56     INFO - Leaving test test_side_by_side_four_column_variant_stops_at_three
[task 2026-08-18T22:38:56.508+00:00] 22:38:56     INFO - Entering test test_single_section_stops_at_four_cards
[task 2026-08-18T22:38:56.509+00:00] 22:38:56     INFO - Buffered messages finished
[task 2026-08-18T22:38:56.509+00:00] 22:38:56     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/browser/browser_newtab_side_by_side_layout.js | test_single_section_stops_at_four_cards - Test timed out
[task 2026-08-18T22:38:57.007+00:00] 22:38:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2026-08-18T22:38:57.008+00:00] 22:38:57     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/browser/browser_newtab_side_by_side_layout.js | profile uploaded in profile_browser_newtab_side_by_side_layout-2.js.json
[task 2026-08-18T22:38:57.009+00:00] 22:38:57     INFO - TEST-UNEXPECTED-TIMEOUT | browser/extensions/newtab/test/browser/browser_newtab_side_by_side_layout.js | Test timed out
[task 2026-08-18T22:38:57.009+00:00] 22:38:57     INFO - TEST-INFO took 48581ms
[task 2026-08-18T22:38:57.108+00:00] 22:38:57     INFO - GECKO(4636) | Completed ShutdownLeaks collections in process 4636
[task 2026-08-18T22:38:57.109+00:00] 22:38:57     INFO - TEST-START | Shutdown

waitForPreloaded's guard could observe a browser as still loading after the
load event it then waited for had already been dispatched, and the wait never
resolved. BrowsingContextWebProgress clears isLoadingDocument while handling
STATE_STOP|STATE_IS_WINDOW, before forwarding that notification to its
listeners, so sampling the flag and listening for STATE_IS_WINDOW cover the
same transition.

A state check followed by BrowserTestUtils.browserLoaded would not: the load
event rides the earlier STATE_STOP|STATE_IS_DOCUMENT, so the wait could be
installed after the only event it wanted. browserLoaded also has to keep
meaning "the next qualifying load", which the many callers that store its
promise before triggering a navigation depend on. waitForPreloaded is the only
caller that needs this, so it stays in the newtab test harness rather than
growing BrowserTestUtils' API.

Assignee: nobody → florian
Status: NEW → ASSIGNED

Every test waited for the content band, which renders from prefs alone, while
the column it measures stays display: contents until the layout has arrived
from the parent process. Wait for .layout-content-column.has-feed instead.

test_side_by_side_with_no_widgets_recenters checked the panel's border colour,
which is opaque currentColor when no panel is generated and transparent for a
real panel over a wallpaper. It checks the pseudo-element's content instead,
which tells the two apart.

Blocks: 2072711
Blocks: 2074031
Pushed by fqueze@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3b6166fffa78 https://hg.mozilla.org/integration/autoland/rev/37fc4a72906f Wait for the content feed's layout in browser_newtab_side_by_side_layout.js, r=mconley.
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: