2064944 - Refactor NativeLayerWaylandRender surface management methods to a helper class

Status: NEW

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Brad Werth [:bradwerth]]

NativeLayer defines some surface API which has platform-specific overrides. NativeLayerWaylandRender is one such override class which is used for non-video surfaces on Wayland. The Wayland GPU process needs an implementation that does almost all of this work, and also handles video surfaces via an implementation of the AttachExternalImage method, and also packages up these calls as commands to send to the parent process over IPC. To help this along, split the surface handling methods in NativeLayerWaylandRender into a helper class that can be used as a composition object on both the parent and GPU processes.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 2064944 Part 2: Refactor NativeLayerWayland into a helper class for surface management.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 2064944 Part 3: Make NativeLayerWaylandRender use the surface helper class.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 2064944 Part 1: Make SurfacePoolWayland accept a nullable WaylandSurfaceLock.

A null lock indicates that the buffers are presented by another process,
so their usage is tracked with the DMABuf global reference counter
instead of Wayland buffer release events. Existing callers pass their
lock by pointer, so behavior is unchanged for them.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6dc014a24fbb
https://hg.mozilla.org/integration/autoland/rev/708d495fc51b
Part 1: Make SurfacePoolWayland accept a nullable WaylandSurfaceLock. r=gfx-reviewers,ahale
https://github.com/mozilla-firefox/firefox/commit/271644a7c76e
https://hg.mozilla.org/integration/autoland/rev/ff7f736e257a
Part 2: Refactor NativeLayerWayland into a helper class for surface management. r=gfx-reviewers,ahale
https://github.com/mozilla-firefox/firefox/commit/bc158a9432a4
https://hg.mozilla.org/integration/autoland/rev/89d52353864a
Part 3: Make NativeLayerWaylandRender use the surface helper class. r=gfx-reviewers,ahale

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/98bddef2a90f
https://hg.mozilla.org/integration/autoland/rev/ebeddb8734cd
Revert "Bug 2064944 Part 3: Make NativeLayerWaylandRender use the surface helper class. r=gfx-reviewers,ahale" for causing build bustages in NativeLayerWaylandSurfaceHandler.cpp

Comment 6

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/layers/NativeLayerWaylandSurfaceHandler.cpp:X:9: error: no member named 'RenderThread' in namespace 'mozilla::wr'