Open Bug 2064952 Opened 3 months ago Updated 8 days ago

Mousing over HDR video on Imgur makes it go dim

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

People

(Reporter: jrmuizel, Unassigned)

References

()

Details

Attachments

(1 obsolete file)

When I mouse over the video to show the controls on https://imgur.com/G0m5sgS it goes dim. I'm macOS 15.7.9

On Windows the video is always showing as BT709 (which is an even worse bug) but the video shifts up by a pixel when the mouse is on it, which makes me think it may be going between overlay/non-overlay modes or something.

Will test on macOS.

Testing on macOS I see the behavior you are describing - the video goes from BT2100 PQ to BT709 when the mouse cursor is on it. On Windows every time I had looked at the video I it was BT709, I did not realize it was a BT2100 PQ video to begin with, which is an even worse bug (imgur not showing videos as HDR correctly at all, not just when player controls are visible).

Brad, can you take a look at what is going on here?

Flags: needinfo?(bwerth)

I can reproduce on macOS. MediaInfo says the downloaded video BT2020 PQ, and it displays fine in its own tab, outside of the Imgur player interface. That interface, whatever effect it is using, prevents the video from being promoted because it is not on the root tile cache. Promotion of the surface is necessary for correct HDR display at least on macOS; probably also on other platforms.

I'll build a patch that ignores this type of promotion failure and see what effects it has on the Imgur case.

Assignee: nobody → bwerth
Severity: -- → S3
Flags: needinfo?(bwerth)
Priority: -- → P3
Summary: Mousing over HDR video makes it go dim → Mousing over HDR video on Imgur makes it go dim

This is another case where it is more important to get correct HDR
display than it is important to apply whatever effect is intended by the
content author.

Glenn, seems like surface promotion is currently only possible if the surface is on a root tile cache. When forced as an underlay, the surface isn't rendered at all. When forced as an overlay, it crashes the GPU process. Is there a way to get around this?

Flags: needinfo?(mozilla)

We don't currently support promotion if it's inside a child surface, that would require some significant changes to webrender (doable, but work) and more importantly a clear set of heuristics on when we want to do this (e.g. there are some things where it's simply not possible, like a perspective transform involved).

Flags: needinfo?(mozilla)
Attachment #9629654 - Attachment is obsolete: true

Taking myself off for now. The longterm fix will be to get HDR working without promoted surfaces. I'll identify the right feature Bug to block against.

Assignee: bwerth → nobody

(In reply to Brad Werth [:bradwerth] from comment #7)

Taking myself off for now. The longterm fix will be to get HDR working without promoted surfaces. I'll identify the right feature Bug to block against.

Looks like the tracking Bug is meta-hdr-images. Meta Bugs are never closed, but that meta is blocked on platform-specific shipping Bugs, so we'll know when we're making progress, per-platform.

See Also: → meta-hdr-images
See Also: → 2091659
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: