2065137 - Test the newtab searchbar SAP with a real search

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Dão Gottwald [:dao]]

Follow-up from D319855.

browser_search_telemetry_sap_newtab_searchbar.js calls BrowserSearchTelemetry.recordSearch directly, so it exercises the recording path but not the New Tab search bar that is meant to reach it. It also asserts only browser.engagement.navigation.newtab_searchbar, while bug 2062210 added the SAP to browser.search.content, browser.search.withads and browser.search.adclicks too.

Drive a real search through the New Tab search bar and assert with SearchUITestUtils.assertSAPTelemetry, covering each metric the SAP was added to.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2065137 - Let promiseSuggestionsPresent find suggestions in a content-process urlbar. r?mbeier!

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2065137 - Test the newtab searchbar SAP by driving a real search. r?mbeier!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79f2d86eb21f
https://hg.mozilla.org/integration/autoland/rev/0ac4bd2b0f43
Let promiseSuggestionsPresent find suggestions in a content-process urlbar. r=mbeier
https://github.com/mozilla-firefox/firefox/commit/7716114a7dd3
https://hg.mozilla.org/integration/autoland/rev/f615ff33f488
Test the newtab searchbar SAP by driving a real search. r=mbeier

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0ac4bd2b0f43
https://hg.mozilla.org/mozilla-central/rev/f615ff33f488