206541 - crasher when printing mail messages

Status: RESOLVED DUPLICATE of bug 216705

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

crasher when printing mail messages

here's the stack:

nsMsgDBView::GetHdrForFirstSelectedMessage(nsMsgDBView * const 0x0359b280, 
nsIMsgDBHdr * * 0x0012ac94) line 5471 + 25 bytes
XPTC_InvokeByIndex(nsISupports * 0x0359b280, unsigned int 26, unsigned int 1, 
nsXPTCVariant * 0x0012ac94) line 102
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode 
CALL_GETTER) line 2023 + 42 bytes
XPCWrappedNative::GetAttribute(XPCCallContext & {...}) line 1884 + 14 bytes
XPC_WN_GetterSetter(JSContext * 0x07aa0d50, JSObject * 0x032401a8, unsigned int 
0, long * 0x07f55358, long * 0x0012af88) line 1316 + 12 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 0, unsigned int 2) line 843 + 23 
bytes
js_InternalInvoke(JSContext * 0x07aa0d50, JSObject * 0x032401a8, long 52695304, 
unsigned int 0, unsigned int 0, long * 0x00000000, long * 0x0012be44) line 935 
+ 20 bytes
js_InternalGetOrSet(JSContext * 0x07aa0d50, JSObject * 0x032401a8, long 
53791888, long 52695304, int 4, unsigned int 0, long * 0x00000000, long * 
0x0012be44) line 978 + 31 bytes
js_GetProperty(JSContext * 0x07aa0d50, JSObject * 0x032401a8, long 53791888, 
long * 0x0012be44) line 2546 + 51 bytes
js_Interpret(JSContext * 0x07aa0d50, long * 0x0012bffc) line 2682 + 2042 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 1, unsigned int 2) line 860 + 13 
bytes
nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJSClass * const 0x032a6188, 
nsXPCWrappedJS * 0x033c5ca8, unsigned short 3, const nsXPTMethodInfo * 
0x01615f90, nsXPTCMiniVariant * 0x0012c398) line 1332 + 22 bytes
nsXPCWrappedJS::CallMethod(nsXPCWrappedJS * const 0x033c5ca8, unsigned short 3, 
const nsXPTMethodInfo * 0x01615f90, nsXPTCMiniVariant * 0x0012c398) line 429
PrepareAndDispatch(nsXPTCStubBase * 0x033c5ca8, unsigned int 3, unsigned int * 
0x0012c448, unsigned int * 0x0012c438) line 117 + 31 bytes
SharedStub() line 147
XPTC_InvokeByIndex(nsISupports * 0x033c5ca8, unsigned int 3, unsigned int 2, 
nsXPTCVariant * 0x0012c5f0) line 102
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode 
CALL_METHOD) line 2023 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x07aa0d50, JSObject * 0x015fe0f8, unsigned int 
1, long * 0x07f55204, long * 0x0012c8d0) line 1284 + 14 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 1, unsigned int 0) line 843 + 23 
bytes
js_Interpret(JSContext * 0x07aa0d50, long * 0x0012d78c) line 2852 + 15 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 1, unsigned int 2) line 860 + 13 
bytes
js_InternalInvoke(JSContext * 0x07aa0d50, JSObject * 0x015fe008, long 23060536, 
unsigned int 0, unsigned int 1, long * 0x0012d9e8, long * 0x0012d8b8) line 935 
+ 20 bytes
JS_CallFunctionValue(JSContext * 0x07aa0d50, JSObject * 0x015fe008, long 
23060536, unsigned int 1, long * 0x0012d9e8, long * 0x0012d8b8) line 3527 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x07aa0ce8, void * 
0x015fe008, void * 0x015fe038, unsigned int 1, void * 0x0012d9e8, int * 
0x0012d9ec, int 0) line 1111 + 33 bytes
nsJSEventListener::HandleEvent(nsJSEventListener * const 0x03dd6b80, 
nsIDOMEvent * 0x01e28370) line 181 + 77 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x0490cd30, 
nsIDOMEvent * 0x01e28370, nsIDOMEventTarget * 0x07ac0930, unsigned int 32, 
unsigned int 7) line 1191 + 20 bytes
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x0490cc60, 
nsIPresContext * 0x03c4a8b8, nsEvent * 0x0012e520, nsIDOMEvent * * 0x0012e444, 
nsIDOMEventTarget * 0x07ac0930, unsigned int 7, nsEventStatus * 0x0012e548) 
line 2190 + 36 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x03a52018, nsIPresContext * 
0x03c4a8b8, nsEvent * 0x0012e520, nsIDOMEvent * * 0x0012e444, unsigned int 7, 
nsEventStatus * 0x0012e548) line 3302
nsXULCommandDispatcher::UpdateCommands(nsXULCommandDispatcher * const 
0x0451a5c8, const nsAString & {...}) line 390
XPTC_InvokeByIndex(nsISupports * 0x0451a5c8, unsigned int 9, unsigned int 1, 
nsXPTCVariant * 0x0012e7fc) line 102
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode 
CALL_METHOD) line 2023 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x07aa0d50, JSObject * 0x015fd5d0, unsigned int 
1, long * 0x07f550c0, long * 0x0012eadc) line 1284 + 14 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 1, unsigned int 0) line 843 + 23 
bytes
js_Interpret(JSContext * 0x07aa0d50, long * 0x0012f998) line 2852 + 15 bytes
js_Invoke(JSContext * 0x07aa0d50, unsigned int 2, unsigned int 2) line 860 + 13 
bytes
js_InternalInvoke(JSContext * 0x07aa0d50, JSObject * 0x06e78728, long 
129456048, unsigned int 0, unsigned int 2, long * 0x03acc9b8, long * 
0x0012fac4) line 935 + 20 bytes
JS_CallFunctionValue(JSContext * 0x07aa0d50, JSObject * 0x06e78728, long 
129456048, unsigned int 2, long * 0x03acc9b8, long * 0x0012fac4) line 3527 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x07aa0ce8, void * 
0x06e78728, void * 0x07b757b0, unsigned int 2, void * 0x03acc9b8, int * 
0x0012fb4c, int 0) line 1111 + 33 bytes
GlobalWindowImpl::RunTimeout(nsTimeoutImpl * 0x07f75b28) line 4945 + 84 bytes
GlobalWindowImpl::TimerCallback(nsITimer * 0x07f75bf8, void * 0x07f75b28) line 
5305
nsTimerImpl::Fire() line 382 + 17 bytes
nsTimerManager::FireNextIdleTimer(nsTimerManager * const 0x0163c858) line 616
nsAppShell::Run(nsAppShell * const 0x015718e8) line 143
nsAppShellService::Run(nsAppShellService * const 0x01571870) line 479
main1(int 2, char * * 0x00271f20, nsISupports * 0x00f16ef0) line 1268 + 32 bytes
main(int 2, char * * 0x00271f20) line 1647 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e9ca90()

m_db was null.

I got into a state where I tried to print a message, and since print isn't 
modal, I didn't see it, and went back to mail and tried to print again (and 
again).  which didn't do anything.  and open up messages in the stand alone msg 
window, which also didn't do anything.

none of those worked, until I went back to the print dialog and hit print.

when all those actions came back, I crashed.

I got some bullet proofing, but I think the print modal issue is the bigger 
deal.

Index: src/nsMsgDBView.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/src/nsMsgDBView.cpp,v
retrieving revision 1.147
diff -u -w -r1.147 nsMsgDBView.cpp
--- src/nsMsgDBView.cpp 16 May 2003 18:23:33 -0000      1.147
+++ src/nsMsgDBView.cpp 21 May 2003 05:00:20 -0000
@@ -5468,6 +5468,10 @@
   // don't assert, it is legal for nothing to be selected
   if (NS_FAILED(rv)) return rv;

+  NS_ASSERTION(m_db, "no db!");
+  if (!m_db)
+    return NS_ERROR_UNEXPECTED;
+
   rv = m_db->GetMsgHdrForKey(key, hdr);
   NS_ENSURE_SUCCESS(rv,rv);
   return NS_OK;

Comment 1

[Wayne Mery (:wsmwk)]

worth keeping?  

(going on 3 years old and no reference points to recreate or shoot.  GetHdrForFirstSelectedMessage isn't found in any fixed bugs)

Comment 2

[Wayne Mery (:wsmwk)]

see []

(In reply to comment #0)
>...
> I got some bullet proofing [for the crash - suggested patch below], but I think the print modal  [bug 144601] issue is the bigger deal.
> 
> Index: src/nsMsgDBView.cpp
> ===================================================================
> RCS file: /cvsroot/mozilla/mailnews/base/src/nsMsgDBView.cpp,v
> retrieving revision 1.147
> diff -u -w -r1.147 nsMsgDBView.cpp
> --- src/nsMsgDBView.cpp 16 May 2003 18:23:33 -0000      1.147
> +++ src/nsMsgDBView.cpp 21 May 2003 05:00:20 -0000
> @@ -5468,6 +5468,10 @@
>    // don't assert, it is legal for nothing to be selected
>    if (NS_FAILED(rv)) return rv;
> 
> +  NS_ASSERTION(m_db, "no db!");
> +  if (!m_db)
> +    return NS_ERROR_UNEXPECTED;
> +
>    rv = m_db->GetMsgHdrForKey(key, hdr);
>    NS_ENSURE_SUCCESS(rv,rv);
>    return NS_OK;

Comment 3

[Andrew Schultz]

A similar patch got checked in as part of bug 216705

*** This bug has been marked as a duplicate of 216705 ***