2065743 - Tag the tests outside browser/components/urlbar that drive the address bar so the urlbar-ipc variant runs them

Status: RESOLVED FIXED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

The urlbar-ipc (uipc) test variant is scoped by MOZHARNESS_TEST_TAG: [urlbar], so it only runs tests whose manifest entry carries the urlbar tag. A number of tests drive the address bar — opening the results popup, reading results, asserting gURLBar.searchMode — but live in manifests tagged searchnontelem, search-telemetry or newtab, so they have never run on the message path.

These nine pass with browser.urlbar.ipc.chromeMessagePassing=true today (verified on try, Linux and Windows), so tagging them is pure coverage with no fix needed:

browser/components/search/test/browser/browser.toml -> tags = "urlbar"

• browser_remote_override.js
• browser_rich_suggestions.js
• browser_searchRestrictToken_privateWindow.js
• browser_search_lastused_pref.js

browser/components/search/test/browser/telemetry/browser.toml -> tags = "urlbar"

• browser_search_telemetry_app_provided_and_overridden.js
• browser_search_telemetry_searchform.js
• browser_search_telemetry_sources.js
• browser_search_telemetry_sources_navigation.js

browser/extensions/newtab/test/browser/browser.toml -> tags = "urlbar"

• browser_topsites_section.js

browser_searchRestrictToken_privateWindow.js is worth calling out: it was previously outside the urlbar try recipe entirely, and that is how a search-mode-Enter regression reached autoland and had to be backed out.

Three further tests in the same sweep — browser_addSearchEngineFromForm.js, browser_trending_suggestions.js and browser_webSearch.js — do fail on the message path. Their tags are being added in the bugs fixing them, so this one stays green.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2065743 - Tag the tests outside browser/components/urlbar that drive the address bar so the urlbar-ipc variant runs them. r?daleharvey!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a513fe0b7087
https://hg.mozilla.org/integration/autoland/rev/a9837bdf5b66
Tag the tests outside browser/components/urlbar that drive the address bar so the urlbar-ipc variant runs them. r=search-reviewers,daleharvey

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a9837bdf5b66