2065981 - Inline simple Temporal getters (Duration, PackedTime, epochNanoseconds)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Peter Lafreniere [:n8pjl]]

Prematurely optimize the simplest of Temporal getters.

These getters all are likely to be widely used soon and all consist of 1-2 fixed-slot loads with a little arithmetic. I found a 5x (Ion, 1.8x in baseline) performance improvement in microbenchmarks by eliminating native call overhead, putting performance on par with plain property access.

Don't worry, I won't be specializing more complex Temporal functions until they start showing up in real profiles.

Comment 1

[Peter Lafreniere [:n8pjl]]

Attachment: Bug 2065981 - Inline trivial Temporal Duration getters. r=anba

Comment 2

[Peter Lafreniere [:n8pjl]]

Attachment: Bug 2065981 - Inline Temporal plain time getters. r=anba

Emit unpacking code inline where no further computation is required.

Comment 3

[Peter Lafreniere [:n8pjl]]

Attachment: Bug 2065981 - Inline Temporal epochMilliseconds getters. r=anba

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8f849f8a216
https://hg.mozilla.org/integration/autoland/rev/33b2c57958bf
Inline trivial Temporal Duration getters. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/21bbc7d3d4e5
https://hg.mozilla.org/integration/autoland/rev/354970cc11fc
Inline Temporal plain time getters. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/ee3fa8f41632
https://hg.mozilla.org/integration/autoland/rev/33d4f87dacc8
Inline Temporal epochMilliseconds getters. r=spidermonkey-reviewers,jandem

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/33b2c57958bf
https://hg.mozilla.org/mozilla-central/rev/354970cc11fc
https://hg.mozilla.org/mozilla-central/rev/33d4f87dacc8