Closed
Bug 2066504
Opened 12 days ago
Closed 10 days ago
Dedupe impressions for a carousel slide that cycles back into view
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
156 Branch
| Tracking | Status | |
|---|---|---|
| firefox156 | --- | fixed |
People
(Reporter: ini, Assigned: ini)
References
Details
Attachments
(1 file)
A carousel slide unmounts its ImpressionStats wrapper while hidden, and the dedupe state that suppresses repeat impressions (impressionCardGuids) lives on that instance, so it is destroyed along with it. Every time a slide rotates back into view it reports a fresh impression, inflating counts for a tab left sitting idle.
|
Assignee | |
Updated•12 days ago
|
Summary: Dedupe impressions for a carousel slide that cylces back into view → Dedupe impressions for a carousel slide that cycles back into view
|
|
Assignee | |
Comment 1•12 days ago
|
||
|
||
Updated•12 days ago
|
Assignee: nobody → ini
Status: NEW → ASSIGNED
Pushed by ini@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/9330dd84d407
https://hg.mozilla.org/integration/autoland/rev/a82fb7025d2e
Dedupe impressions for a carousel slide that cycles back into view. r=thecount
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
status-firefox156:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
|
||
Updated•3 days ago
|
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in
before you can comment on or make changes to this bug.
Description
•