Open Bug 2066550 Opened 2 months ago Updated 2 months ago

Thunderbird crashes when opening/viewing Calendar while a macOS accessibility client is in use

Categories

(Calendar :: Calendar Frontend, defect, P1)

Thunderbird 155
x86_64
macOS
defect

Tracking

(thunderbird_esr153 unaffected, thunderbird155 affected)

Tracking Status
thunderbird_esr153 --- unaffected
thunderbird155 --- affected

People

(Reporter: klamping, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Thunderbird crashes on macOS when opening/viewing Calendar while an accessibility client is active. Confirmed with VoiceOver and Magnet (window manager that needs Accessibility privileges).

The crash occurs in mozTableAccessible::isLayoutTablePart when macOS accessibility clients query Thunderbird Calendar grid. This is an issue with Gecko's macOS accessibility implementation. and likely not caused by Thunderbird's code.

The crash started after the Calendar day/week view added ARIA grid semantics in Bug 2056143 / changeset 9dacd7285586.

Environment

  • Thunderbird Beta 155.0b3 (aarch64)
  • macOS 26.6.2 (25G83)
  • Apple Silicon ARM64

Suspected Cause

Likely regressed by commit 9dacd7285586 (Pushlog)
Bug 2056143 - Fix bct1 failures part 2 - Fix calendar a11y click targets.

Relevant added code in calendar/base/content/calendar-multiday-view.js:

this.setAttribute("role", "grid");
hourRow.setAttribute("role", "row");
hourBox.setAttribute("role", "gridcell");

Local testing confirms that reverting this commit prevents the crash.

Trigger

The ARIA grid/row/gridcell structure causes Calendar day/week columns to expose table-like accessible objects. When Magnet or VoiceOver queries accessibilityRole, Gecko reaches mozTableAccessible::isLayoutTablePart and appears to dereference a null pointer. This is not specific to Calendar data or account type.

Steps to reproduce

  1. Enable/run a macOS accessibility client (e.g,. Magnet or VoiceOver)
  2. Start Thunderbird in the inbox view.
  3. Open the Calendar tab.
    4a. If Magnet is running, crash will occur within a few seconds
    4b. If VoiceOver is used, you need to tab focus into the main calendar, which should immediately crash the program

Actual Result

Thunderbird crashes with EXC_BAD_ACCESS (SIGSEGV) at null address.
Top stack:

0 XUL -[mozTableAccessible isLayoutTablePart] + 164
1 XUL -[mozTablePartAccessible moxRole] + 48
2 XUL -[MOXAccessibleBase accessibilityAttributeValue:] + 160
3 AppKit NSAccessibilityGetObjectForAttributeUsingLegacyAPI

With VoiceOver, the report includes:

voucherInfos:
originatorName: "VoiceOver"
proximateName: "VoiceOver"
thread_id: 2057396

With Magnet, the report similarly identifies Magnet as the accessibility caller.

Workaround:

In the Settings Config Editor, set the 'accessibility.force_disabled' pref to 1.

Notes

Magnet triggered the crash through CopyAttributeValue
VoiceOver triggered the same crash path through CopyMultipleAttributeValues
This shows the issue is not Magnet-specific. Any macOS accessibility client that queries the relevant Calendar grid accessible can trigger it.

See Also: → 2066575

Sounds like we need to back out bug 2056143 from 155, before this hits users (155 beta->release merge today).

Flags: needinfo?(corey)
Flags: needinfo?(arschmitz)
Priority: -- → P1

IIRC the v155 backout happend, but no mention in this bug.
Now it's the same for v156's merge today

I thin the conversation happened in the release drivers on matrix. The assumption had been since a patch was already up to fix firefox it would have happened by now but the patch still needs updates as of today.

Flags: needinfo?(arschmitz)

Yes, it was backed out. I posted in the original bug but missed updating here.
https://hg-edge.mozilla.org/releases/comm-beta/rev/8462e76a8758478eef7cee459e9af50fc7fde10c

This was backed out of 155. Just to confirm, it should be backed out of 156 now. Should we back it out on all branches?

Flags: needinfo?(corey)

Looks like a fix just landed in bug 2066575 for v157, so backout out for v156 should be enough

The fix is being uplifted to 156 in FF

You need to log in before you can comment on or make changes to this bug.