Closed Bug 2066673 Opened 2 months ago Closed 2 months ago

TaskCluster tasks on enterprise-firefox repo to report enterprise-firefox-try results

Categories

(Enterprise Products :: Firefox, task)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

To make bug 2066669 actionable, we are going to expect developpers to run try pushes. As of how TaskCluster integration is made with GitHub checks, and given enterprise-firefox and enterprise-firefox-try are distincts repositories, we cannot surface tasks state from enterprise-firefox-try to PRs running from enterprise-firefox: the taskcluster route for those is "checks" and the required changes would be on the github service side.

Part of the github try plan https://docs.google.com/document/d/1PvT0PCDsoBKxvN9XUeP7b2O9YJAMZOHYVXqJC9vU_Mo/edit?tab=t.ntqqur3dd3nh involves steps that should make this work in the future.

Until then the idea is to have a custom github actions tied to a github workflow running on our PRs that will:

  • look at enterprise-firefox-try repository for a branch matching the PR branch name
  • find its first commit
  • query treeherder API for the push id of that commit
  • poll for the jobs state of that push id until either the action times out (github is 6h max) or the jobs completes
  • report those states on the github checks status

This can be implemented purely in taskcluster:

  • try-status-gen runs at decision time, and will be a task that is going to find / monitor for enterprise-firefox-try pushes: expects a branch that matches the name of the PR and that the second commit of that branch is the same as the first commit of the PR
  • this task will then wait on the decision task of the try push to be completed
  • once it is done, it will look at all the generated tasks for the try push
  • for each one of those, it will generate a reporting task that will simply copy the output of the try push task, making it its dependency so it runs only when the task is finished
  • those tasks are renamed with try-status-report- prefix and also try- prefix on treeherder platform
  • wiring github check using checks route and treeherder routes as well so they report on both
Summary: GitHub Action on enterprise-firefox repo to report enterprise-firefox-try results → TaskCluster tasks on enterprise-firefox repo to report enterprise-firefox-try results

Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/98529371d59e964c08441e0be8d4e0ff5fffcac5
[enterprise-main] Bug 2066673 - Add a try-status-report task to forward from try to Treeherder/Github Checks

Authored by https://github.com/lissyx
https://github.com/mozilla/enterprise-firefox/commit/ea544a2295523fff05ee62f3b88d33ba023b385f
[enterprise-main] Merge pull request #1344 from lissyx/enterprise-bug2066673_try_task_status

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Flags: qe-verify-
Depends on: 2068453
Blocks: 2069533
Blocks: 2082343
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: