Closed Bug 2066710 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62209 - Patch aioquic so that it sends a truthful max_udp_payload_size

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62209
Details from upstream follow.

Sam Sneddon <gsnedders@apple.com> wrote:

Patch aioquic so that it sends a truthful max_udp_payload_size

https://github.com/aiortc/aioquic/pull/648 is open for this, but with aioquic having dropped support for Python 3.9, we'd need to fork (and ship wheels, etc.).

Thus, as an immediately workable alternative, we patch aioquic at runtime to fix the issue.

This impacts https://wpt.fyi/results/webtransport?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2026-webtransport%20streams-echo%20or%20echo-large-bidirectional, when using Apple's Network framework, which uses the min of the remote's max_udp_payload_size and ~9K as the max datagram size for loopback — and then, on those tests, when it tries to send a datagram greater than 1500, aioquic drops the packet, and the test eventually times out.

The relevant code in aioquic, for reference, is: https://github.com/aiortc/aioquic/blob/1.2.0/src/aioquic/_crypto.c#L126-L129 and https://github.com/aiortc/aioquic/blob/1.2.0/src/aioquic/quic/connection.py#L939-L950

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/60c1c33b6f40 https://hg.mozilla.org/integration/autoland/rev/851c43cfdc7e [wpt PR 62209] - Patch aioquic so that it sends a truthful max_udp_payload_size, a=testonly

Test result changes from PR not available.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.