[wpt-sync] Sync PR 62212 - [css-mixins] Add !important test follow-ups
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62212 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62212
Details from upstream follow.
Brandon Walderman <brwalder@microsoft.com> wrote:
[css-mixins] Add !important test follow-ups
Follow up on post-submit review feedback by covering !important after a
brace-wrapped dashed-function argument. Also make the mixin result test
use green for the expected behavior and red for the fallback, so
failures are easier to interpret.Bug: 542582974
Test: external/wpt/css/css-mixins/functions/dashed-function-parsing.html
Test: external/wpt/css/css-mixins/mixins/important.html
Change-Id: I1da48f90e2083747b351b08dc3a7f312620fe259
Reviewed-on: https://chromium-review.googlesource.com/8290708
WPT-Export-Revision: 9e0b9228bad0578d7617ce17d1d91971686f6df7
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b89f4173adc852ace18cb9d9dade02e53bcf5389
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 4 subtests
Status Summary
Firefox
OK : 2
PASS: 36
FAIL: 20
Chrome
OK : 2
PASS: 56
Safari
OK : 2
PASS: 54
FAIL: 2
Links
Details
Firefox-only Failures
- /css/css-mixins/functions/dashed-function-parsing.html [wpt.fyi]
- e.style['top'] = "--func()" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(auto)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(100px)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(#fff)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(auto, 100px, #fff)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(auto ,100px ,#fff)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(auto , 100px , #fff)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(auto,100px,#fff)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func("thing")" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func(--bar(), --baz(--fez()))" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({1}, 2)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({ 1}, 2)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({1 }, 2)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({ 1 }, 2)" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({1},{2})" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({1, 2, 3},{4})" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({,},{4})" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({{}},{4})" should set the property value:
FAILlinked bug:Bug 2053886 - e.style['top'] = "--func({[]},{4})" should set the property value:
FAILlinked bug:Bug 2053886
- e.style['top'] = "--func()" should set the property value:
New Tests That Don't Pass
- /css/css-mixins/functions/dashed-function-parsing.html [wpt.fyi]
- e.style['top'] = "--func()" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(auto)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(100px)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(#fff)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(auto, 100px, #fff)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(auto ,100px ,#fff)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(auto , 100px , #fff)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(auto,100px,#fff)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func("thing")" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func(--bar(), --baz(--fez()))" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({1}, 2)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({ 1}, 2)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({1 }, 2)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({ 1 }, 2)" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({1},{2})" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({1, 2, 3},{4})" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({,},{4})" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({{}},{4})" should set the property value:
FAIL(Chrome:PASS, Safari:PASS) - e.style['top'] = "--func({[]},{4})" should set the property value:
FAIL(Chrome:PASS, Safari:PASS)
- e.style['top'] = "--func()" should set the property value:
- /css/css-mixins/mixins/important.html [wpt.fyi]
- !important is valid in mixin result declarations:
FAIL(Chrome:PASS, Safari:FAIL)
- !important is valid in mixin result declarations:
Comment 4•2 months ago
|
||
| bugherder | ||
Description
•