2066836 - Remove Legacy Telemetry "third-party-modules" ping

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

We've been sending a Glean "third-party-modules" ping since last June (Firefox 141). It's probably time to stop sending the Legacy version.

Comment 1

[Chris H-C :chutten]

:gstoll do you need any help migrating analyses over, or have they all moved already in the past year?

Comment 2

[Greg Stoll :gstoll]

I don't think so - is it correct that Glean data is in the firefox_desktop table (and not telemetry)? If so, feel free to do this; thanks!

Comment 3

[Chris H-C :chutten]

Correct! Glean ping datasets have views at mozdata.<application_id>.<ping_name> (mozdata is often implicit and can be omitted) so the Firefox Desktop stuff will indeed be at firefox_desktop.third_party_modules.

If you ever need this information again (or a starting place to access your data), you can find it on the Glean Dictionary: https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/pings/third-party-modules

Comment 4

[Chris H-C :chutten]

Attachment: Bug 2066836 - Remove Legacy Telemetry 'third-party-modules' ping r?gstoll

Leaves the timer and notification stuff in-place in t/c/telemetry.
Future work: we should probably move this stuff to
toolkit/xre/dllservices or someplace closer to the team that uses the
data.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e5489dfd742
https://hg.mozilla.org/integration/autoland/rev/28dcf45cc346
Remove Legacy Telemetry 'third-party-modules' ping r=gstoll

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60a8cd752bf5
https://hg.mozilla.org/integration/autoland/rev/d7650582ca1d
Revert "Bug 2066836 - Remove Legacy Telemetry 'third-party-modules' ping r=gstoll" for causing xpc and docu failures @ test_ThirdPartyModulesPing.js

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing xpc and docu failures @ test_ThirdPartyModulesPing.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d7650582ca1d8cdcd51245b7df5ba037e8778aa9

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_ThirdPartyModulesPing.js | test_send_ping - [test_send_ping : 162] Trustworthiness == expected for module: modules-test.dll - true == false

Comment 8

[Chris H-C :chutten]

Ah, whoops. Silly mistake.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c5367415d23a
https://hg.mozilla.org/integration/autoland/rev/1187f23f1a4f
Remove Legacy Telemetry 'third-party-modules' ping r=gstoll

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1187f23f1a4f