Closed Bug 2066879 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 62220 - Properly tree-scope keyframe animated property values

Categories

(Core :: CSS Transitions and Animations, task, P4)

task

Tracking

()

RESOLVED FIXED
157 Branch
Tracking Status
firefox157 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62220 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62220
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Properly tree-scope keyframe animated property values

The missing EnsureScopedValue() triggered a recently added CHECK() for
IsScopedValue() in various ApplyValue() paths.

This also revealed an existing correctness issue when animating
tree-scoped names where we would fall back to using the Document as the
tree-scope also when lookup should start from a shadow tree.

The StyleCascade::Resolve() function for substitutions in style rule
cascading already had an EnsureScopedValue(), but the one used by
animations did not.

Bug: 552026567, 552689401
Change-Id: I2826c567e94288efae6d0ff9bcadbd68a54f0e6b

Reviewed-on: https://chromium-review.googlesource.com/8295800
WPT-Export-Revision: d6aa97a36a8bab47873ebd7a06498f9ba04888fd

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 202 tests and 1 subtests

Status Summary

Firefox

OK : 125
PASS : 1[GitHub] 45[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1402[Gecko-android-em-14-x86_64-lite-opt-geckoview] 1419[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1445[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug] 1446[Gecko-linux2404-64-debug] 1447[Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
FAIL : 30[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR: 1[Gecko-linux2404-64-debug] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug]

Chrome

FAIL : 1

Safari

FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in before you can comment on or make changes to this bug.