[wpt-sync] Sync PR 62220 - Properly tree-scope keyframe animated property values
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62220 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62220
Details from upstream follow.
Rune Lillesveen <futhark@chromium.org> wrote:
Properly tree-scope keyframe animated property values
The missing EnsureScopedValue() triggered a recently added CHECK() for
IsScopedValue() in various ApplyValue() paths.This also revealed an existing correctness issue when animating
tree-scoped names where we would fall back to using the Document as the
tree-scope also when lookup should start from a shadow tree.The StyleCascade::Resolve() function for substitutions in style rule
cascading already had an EnsureScopedValue(), but the one used by
animations did not.Bug: 552026567, 552689401
Change-Id: I2826c567e94288efae6d0ff9bcadbd68a54f0e6bReviewed-on: https://chromium-review.googlesource.com/8295800
WPT-Export-Revision: d6aa97a36a8bab47873ebd7a06498f9ba04888fd
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f11ccb185af4e49eb0b6208bf9165aa46a0a50d
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 202 tests and 1 subtests
Status Summary
Firefox
OK : 125
PASS : 1[GitHub] 45[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1402[Gecko-android-em-14-x86_64-lite-opt-geckoview] 1419[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1445[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug] 1446[Gecko-linux2404-64-debug] 1447[Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
FAIL : 30[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR: 1[Gecko-linux2404-64-debug] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-debug]
Chrome
FAIL : 1
Safari
FAIL : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-animations/animation-delay-010.html [wpt.fyi]:
SKIP - /css/css-animations/animation-delay-012.html [wpt.fyi]:
ERROR[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug],PASS[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt] - /css/css-animations/animation-duration-infinite.html [wpt.fyi]:
ERROR[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-windows11-64-25h2-debug],PASS[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt] - /css/css-animations/animation-important-002.html [wpt.fyi]:
FAIL - /css/css-animations/animation-name-in-nested-shadow.html [wpt.fyi]:
FAIL - /css/css-animations/animation-name-in-shadow-part-outer-match.html [wpt.fyi]:
FAIL - /css/css-animations/KeyframeEffect-getKeyframes.tentative.html [wpt.fyi]
- KeyframeEffect.getKeyframes() returns expected frames for an animation with multiple keyframes for the same time and with different easing functions and composite operations:
FAIL - KeyframeEffect.getKeyframes() returns expected values for animations with a CSS variable which is overriden by the value in keyframe:
FAIL - KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe:
FAIL
- KeyframeEffect.getKeyframes() returns expected frames for an animation with multiple keyframes for the same time and with different easing functions and composite operations:
- /css/css-animations/animate-with-background-color-oklch-002.html [wpt.fyi]
- Animate from legacy rgb to oklch:
FAIL - Animate from legacy rgb to color-mix oklch:
FAIL
- Animate from legacy rgb to oklch:
- /css/css-animations/animate-with-color-mix-2.html [wpt.fyi]
- animate-with-color-mix-2:
FAIL
- animate-with-color-mix-2:
- /css/css-animations/animate-with-color-mix.html [wpt.fyi]
- Animate from neutral keyframe with color-mix to legacy rgb:
FAIL - Animate from legacy rgb to neutral keyframe with color-mix:
FAIL - Animate from neutral keyframe with color-mix to srgb:
FAIL - Animate from srgb to neutral keyframe with color-mix:
FAIL - Animate from color-mix with transparency to legacy rgba:
FAIL - Animate from legacy rgba to color-mix with transparency:
FAIL
- Animate from neutral keyframe with color-mix to legacy rgb:
- /css/css-animations/animate-with-relative-color.html [wpt.fyi]
- Animate from absolute oklch to relative oklch:
FAIL - Animate from color keyword to relative rgb:
FAIL
- Animate from absolute oklch to relative oklch:
- /css/css-animations/display-none-dont-cancel-pseudo.tentative.html [wpt.fyi]
- A CSS Animation on a pseudo-element animating to "display: none" with "fill: forwards" remains active after animation completion.:
FAIL
- A CSS Animation on a pseudo-element animating to "display: none" with "fill: forwards" remains active after animation completion.:
- /css/css-animations/event-dispatch.tentative.html [wpt.fyi]
- Replacing a running animation should get animationcancel earlier than animationstart:
FAIL - The cancel event should be fired before the new start event if both have the same position in the animation list:
FAIL
- Replacing a running animation should get animationcancel earlier than animationstart:
- /css/css-animations/revert-rule-keyframes-dynamic.html [wpt.fyi]
- revert-rule in keyframes, reverted-to value changing (standard property):
FAIL - revert-rule in keyframes, reverted-to value changing (custom property):
FAIL
- revert-rule in keyframes, reverted-to value changing (standard property):
- /css/css-animations/revert-rule-keyframes.html [wpt.fyi]
- revert-rule in keyframes (width):
FAIL - revert-rule in keyframes (--x):
FAIL
- revert-rule in keyframes (width):
- /css/css-animations/parsing/keyframe-selectors.html [wpt.fyi]
- 'calc(10%)' should be a valid keyframe selector:
FAIL - 'calc(10% * sibling-index())' should be a valid keyframe selector:
FAIL - 'calc(10% * sign(1em - 1px))' should be a valid keyframe selector:
FAIL - 'entry calc(10%)' should be a valid keyframe selector:
FAIL - 'exit calc(60%)' should be a valid keyframe selector:
FAIL
- 'calc(10%)' should be a valid keyframe selector:
- /css/css-animations/parsing/keyframes-allowed-properties.html [wpt.fyi]
- @keyframes allows all non-animation properties and animation-timing-function:
FAIL
- @keyframes allows all non-animation properties and animation-timing-function:
- /css/css-animations/responsive/column-rule-color-001.html [wpt.fyi]
- column-rule-color responds to inherited changes:
FAIL
- column-rule-color responds to inherited changes:
- /css/css-animations/responsive/column-width-001.html [wpt.fyi]
- column-width responds to inherited changes:
FAIL
- column-width responds to inherited changes:
- /css/css-animations/responsive/fill-forwards-viewport-units.html [wpt.fyi]
- fill: forwards with viewport units updates on viewport resize:
FAIL
- fill: forwards with viewport units updates on viewport resize:
Tests Disabled in Gecko Infrastructure
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/10bb32d3954e
https://hg.mozilla.org/mozilla-central/rev/1c2dccf44aaa
Description
•