2067179 - Remove unused AboutReaderParent._getArticle

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, task, P1)

Description

[Mike Kaply [:mkaply]]

Filing as a good first bug to learn workflows.

AboutReaderParent._getArticle() has no callers anywhere in the tree, including tests. Reader Mode downloads articles from the child side (AboutReader._loadArticle calls ReaderMode.downloadAndParseDocument directly), so this parent-side wrapper is dead code. Please remove the method along with its JSDoc comment (lines 261-278).

Link to the code:
https://searchfox.org/firefox-main/rev/64e3d949f357db531c6deb0444ace3ba134d73e0/browser/actors/AboutReaderParent.sys.mjs#261-278

Note that the lazy ReaderMode module getter at the top of the file is still needed: it is used by leaveReaderMode(). Only the method goes away.

To verify the fix:

Confirm the definition was the only reference (prints one line before your patch, nothing after):
rg -n '_getArticle(' browser/ toolkit/

Then run the Reader Mode tests and the linters:
./mach test toolkit/components/reader/tests/browser
./mach lint --outgoing

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Jieke Jiang]

Attachment: Bug 2067179 - Remove unused AboutReaderParent._getArticle. r=#firefox-desktop-core-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1549b739a72
https://hg.mozilla.org/integration/autoland/rev/dccd5616f27e
Remove unused AboutReaderParent._getArticle. r=firefox-desktop-core-reviewers ,dao

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dccd5616f27e