2067218 - Setup the background notifications helper on windows

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, task, P1)

Description

[Harshit Sohaney [:hsohaney]]

This bug tracks setting up the new helper executable that will be responsible for maintaining a websocket connection to the dom.push.serverURL when firefox is closed. It is also responsible for opening firefox in headless mode to fetch notifications when the server lets us know that there are some.

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Setup the push notification helper for windows. r=iholmes,aborondo,nrishel

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Accept a --profile argument in the notification helper. r=aborondo,iholmes,nrishel

Comment 3

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Add a Nimbus-controlled pref gating the notification helper. r=aborondo,iholmes,nrishel

Comment 4

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Stop the notification helper when the pref is disabled. r=aborondo,iholmes,nrishel

Comment 5

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Add a mutex to avoid duplicate helpers for a profile. r=aborondo,iholmes,nrishel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/409169d0ff14
https://hg.mozilla.org/integration/autoland/rev/304b4ae0a3af
Setup the push notification helper for windows. r=aborondo

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/304b4ae0a3af

Comment 8

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2067218 - Introduce a stop all helpers event. r=aborondo,iholmes,nrishel

Comment 9

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 10

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2067218 - Make the broadcast stop event reach every user's helpers r=iholmes,hsohaney,nrishel

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9847f3710831
https://hg.mozilla.org/integration/autoland/rev/b688a0e5ec9d
Accept a --profile argument in the notification helper. r=aborondo,nrishel
https://github.com/mozilla-firefox/firefox/commit/b71eec14bfc5
https://hg.mozilla.org/integration/autoland/rev/c70474ede0ba
Add a Nimbus-controlled pref gating the notification helper. r=iholmes
https://github.com/mozilla-firefox/firefox/commit/476a5071469e
https://hg.mozilla.org/integration/autoland/rev/0471bbb96e9a
Stop the notification helper when the pref is disabled. r=aborondo,nrishel
https://github.com/mozilla-firefox/firefox/commit/95a29fb0af37
https://hg.mozilla.org/integration/autoland/rev/8163167a1f40
Add a mutex to avoid duplicate helpers for a profile. r=aborondo,nrishel

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b48578dc3b36
https://hg.mozilla.org/integration/autoland/rev/2b669a443209
Revert "Bug 2067218 - Add a mutex to avoid duplicate helpers for a profile. r=aborondo,nrishel" for causing multiple marionette tests failures.

Comment 13

[Iulian Moraru]

Revert for causing multiple marionette tests failures.

• Push with failures

• Failure log

• Failure log

• Backout link

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a5088d7df51
https://hg.mozilla.org/integration/autoland/rev/78468f501530
Accept a --profile argument in the notification helper. r=aborondo,nrishel
https://github.com/mozilla-firefox/firefox/commit/c97c572f155e
https://hg.mozilla.org/integration/autoland/rev/7c3644b86b34
Add a Nimbus-controlled pref gating the notification helper. r=iholmes
https://github.com/mozilla-firefox/firefox/commit/3677152c51e4
https://hg.mozilla.org/integration/autoland/rev/7d78dd3992f1
Stop the notification helper when the pref is disabled. r=aborondo,nrishel
https://github.com/mozilla-firefox/firefox/commit/b29233727193
https://hg.mozilla.org/integration/autoland/rev/7ff1aab4dfea
Add a mutex to avoid duplicate helpers for a profile. r=aborondo,nrishel

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/78468f501530
https://hg.mozilla.org/mozilla-central/rev/7c3644b86b34
https://hg.mozilla.org/mozilla-central/rev/7d78dd3992f1
https://hg.mozilla.org/mozilla-central/rev/7ff1aab4dfea

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9dada8156e86
https://hg.mozilla.org/integration/autoland/rev/af47b324781d
Introduce a stop all helpers event. r=aborondo,nrishel
https://github.com/mozilla-firefox/firefox/commit/147507e074b4
https://hg.mozilla.org/integration/autoland/rev/190b610df9a9
Make the broadcast stop event reach every user's helpers r=iholmes

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/af47b324781d
https://hg.mozilla.org/mozilla-central/rev/190b610df9a9