Closed
Bug 2067224
Opened 2 months ago
Closed 2 months ago
[customizable-menu] Add a MenuGridContainer and MenuGridItem composables to compose-menu
Categories
(Firefox for Android :: Menu, task)
Tracking
()
RESOLVED
FIXED
157 Branch
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: petru, Assigned: giorga)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-core])
Attachments
(1 external file)
Based on the recent investigation most menu items share a similar structure and UI.
These will be used instead of MenuNavigation and LibraryMenuGroup from Fenix to allow displaying a grid of menu items.
The only difference between the two grid UI approaches is the background of the container / cells.
The AC composable should support 3 variations:
surfacecontainer background - for the navigation itemssurfaceContainerHighcontainer background - when the menu overflows the screen and the grid section becomes stickysurfaceBrightitems background + dividers - for the library items
The surfaceContainerHigh container colour should be set automatically.
The choice between the surface container background and surfaceBright items background + dividers should be of the integrators -> the menu section should allow passing this as a parameter, maybe as a useDividers boolean property.
Note: The menu item should support an optional long-press interaction - needed by navigation.
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
Assignee: nobody → giorga
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed by giorga@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/90060b79d462
https://hg.mozilla.org/integration/autoland/rev/151e0ac9a1ae
[customizable-menu] Add a MenuGridContainer and MenuGridItem composables to compose-menu r=android-reviewers,petru
Comment 3•2 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox157:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•