Closed
Bug 2067302
Opened 1 month ago
Closed 28 days ago
Fix misspellings in SearchService.shouldShowInstallPrompt
Categories
(Firefox :: Search, task, P5)
Firefox
Search
Tracking
()
RESOLVED
FIXED
157 Branch
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: scunnane, Assigned: sfshah, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
identifier is misspelled throughout SearchService.shouldShowInstallPrompt and should be corrected.
Hi,
New contributor here, hoping to have a patch for this done soon.
|
||
Updated•28 days ago
|
Attachment #9632848 -
Attachment is obsolete: true
Hi, I've got a patch ready and I was wondering if there are any tests that I should run? Here's the phabricator link: https://phabricator.services.mozilla.com/D322390
Flags: needinfo?(scunnane)
|
Reporter | |
Comment 5•28 days ago
|
||
Great, thank you for this patch. You can run $ ./mach test toolkit/components/search for good measure.
Flags: needinfo?(scunnane)
|
|
Reporter | |
Updated•28 days ago
|
Assignee: scunnane → sfshah
Pushed by scunnane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/bdf8dc0e52be
https://hg.mozilla.org/integration/autoland/rev/9b2c20580004
Fix misspellings in SearchService.shouldShowInstallPrompt. r=scunnane,search-reviewers
|
||
Comment 7•28 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 28 days ago
status-firefox157:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
|
||
Updated•26 days ago
|
QA Whiteboard: [search][qa-triage-done-c157/b156]
You need to log in
before you can comment on or make changes to this bug.
Description
•