Open Bug 2067351 Opened 2 months ago Updated 2 months ago

The stylelint task is not scheduled when tools/lint/stylelint.yml changes

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(Not tracked)

People

(Reporter: dao, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=yaml])

Filing as a good first bug to learn workflows.

The stylelint CI task lists the files that should schedule it, and one entry is misspelled: 'tools/lint/styleint.yml' instead of 'tools/lint/stylelint.yml'. A patch that changes only the linter's own mozlint configuration therefore does not run the linter. The eslint task a few blocks above spells its own entry correctly, which is what the stylelint one should look like.

Link to the code:
https://searchfox.org/firefox-main/source/taskcluster/kinds/source-test/mozlint.yml#216

The fix is to correct the spelling so the entry names the file that actually exists, tools/lint/stylelint.yml.

To verify the fix:

ls tools/lint/stylelint.yml
./mach lint -l yaml taskcluster/kinds/source-test/mozlint.yml

The first command confirms the corrected path exists in the tree (the misspelled one does not); the second confirms the file is still valid YAML. A reviewer can confirm the scheduling change itself.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

See Also: → 2067353
You need to log in before you can comment on or make changes to this bug.