Open Bug 2067435 Opened 4 days ago Updated 15 hours ago

Audio icon in pinned tab shrunk due to border change

Categories

(Firefox :: Tabbed Browser, defect, P3)

Firefox 157
defect
Points:
1

Tracking

()

Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox155 --- unaffected
firefox156 --- unaffected
firefox157 --- fix-optional

People

(Reporter: mercichao, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-nova])

Attachments

(1 file)

Attached image Region.png

Because of the recent change to .tab-icon-overlay which adds a border, the audio icon in pinned tabs is shrunk down from the original 12px (size of the SVG image) to 10px. This visual regression makes the icon appear smaller than intended. Adjusting the styling can fix the issue:

  • Change the padding to 1px, or
  • Replace the padding with object-fit: scale-down.
Keywords: regression
Regressed by: 2048382

Sorry that if choosing the approach of adjust the padding, the new padding should be calc(2px - env(hairline)).

:kpatenio, since you are the author of the regressor, bug 2048382, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(kpatenio)

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidefe-nova]

Note that the 1px border is only on the audio-related variants of the .tab-icon-overlay https://searchfox.org/firefox-main/rev/bde88e0509310cea9d16d473d94d7d0f48632df2/browser/themes/shared/tabbrowser/tabs.css#697 while all variants of the overlay currently use the 2px padding https://searchfox.org/firefox-main/rev/bde88e0509310cea9d16d473d94d7d0f48632df2/browser/themes/shared/tabbrowser/tabs.css#647. Makes sense to reduce padding on the audio-related variants.

Points: --- → 1
Flags: needinfo?(kpatenio)
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: