2067435 - Audio icon in pinned tab shrunk due to border change

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Merci chao]

Attachment: Region.png

Because of the recent change to .tab-icon-overlay which adds a border, the audio icon in pinned tabs is shrunk down from the original 12px (size of the SVG image) to 10px. This visual regression makes the icon appear smaller than intended. Adjusting the styling can fix the issue:

• Change the padding to 1px, or
• Replace the padding with object-fit: scale-down.

Comment 1

[Merci chao]

Sorry that if choosing the approach of adjust the padding, the new padding should be calc(2px - env(hairline)).

Comment 2

[BugBot [:suhaib / :marco]]

:kpatenio, since you are the author of the regressor, bug 2048382, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 4

[Stephen Thompson [:sthompson]]

Note that the 1px border is only on the audio-related variants of the .tab-icon-overlay https://searchfox.org/firefox-main/rev/bde88e0509310cea9d16d473d94d7d0f48632df2/browser/themes/shared/tabbrowser/tabs.css#697 while all variants of the overlay currently use the 2px padding https://searchfox.org/firefox-main/rev/bde88e0509310cea9d16d473d94d7d0f48632df2/browser/themes/shared/tabbrowser/tabs.css#647. Makes sense to reduce padding on the audio-related variants.

Comment 5

[kpatenio]

Attachment: Bug 2067435 - use outline to increase audio overlay icon size for collapsed and pinned tabs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1dd26280cb97
https://hg.mozilla.org/integration/autoland/rev/8a9ececd49e3
use outline to increase audio overlay icon size for collapsed and pinned tabs r=desktop-theme-reviewers,tabbrowser-reviewers,sthompson,emilio

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8a9ececd49e3

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox157 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[kpatenio]

This is okay to land in 158