2067606 - Enable trending and recent search on the Homepage Search by default

Status: RESOLVED FIXED

(Firefox for Android :: Search, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Enable trending and recent search on the Homepage Search by default for all channels and remove the nimbus flags and secret settings. Do not remove the Nimbus flags, but removing the Secret Setting should be fine.

Reference:

• https://searchfox.org/firefox-main/rev/0b76543aaeeeb2a5748ce2675ee36e7c94cb1125/mobile/android/fenix/app/nimbus.fml.yaml#1278

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2067606 - Enable trending and recent search on the Homepage Search by default

• Keep the Nimbus feature for experimentation, but remove the Secret Setting now that the feature is enabled on all channels.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea90974d93c6
https://hg.mozilla.org/integration/autoland/rev/f255289101e7
Enable trending and recent search on the Homepage Search by default r=android-reviewers,skhan

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f255289101e7

Comment 4

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla/enterprise-firefox/commit/ea90974d93c6dbfdf71b12c2d4f482323e030eda
[enterprise-main] Bug 2067606 - Enable trending and recent search on the Homepage Search by default r=android-reviewers,skhan

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

[Tracking Requested - why for this release]:
Looking to uplift this to 156 Beta.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Enablse Trending and Recent Search on the Homepage on by default. This has been enabled in Nightly 155 and was rolled out via Nimbus experimeneter.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Has already been QA verified in Nightly 155 https://mozilla-hub.atlassian.net/browse/QA-5509
• String changes made/needed?: None
• Is Android affected?: yes

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2067606 - Enable trending and recent search on the Homepage Search by default

• Keep the Nimbus feature for experimentation, but remove the Secret Setting now that the feature is enabled on all channels.

Original Revision: https://phabricator.services.mozilla.com/D322937

Comment 8

[Donal Meehan [:dmeehan]]

:gl, with 2 weekly releases, this could ride the train with Fx157? Why should we uplift it?

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Donal Meehan [:dmeehan] from comment #8)

:gl, with 2 weekly releases, this could ride the train with Fx157? Why should we uplift it?

Product (John Hall) wanted this sooner in Fx156.

Comment 10

[jhall]

The plan is the Release this ON by default to all users, while simultaneously running a small holdback experiment for 4 weeks to measure impact (After which we can either iterate, or clean up the nimbus flag/fork in the codebase).

Landing in 156 would mean we could ideally have results in 157 cycle and make change by 158. This will let us begin working on future iteration plans for search suggestion surface, and transition animations with confidence. Waiting until 157 runs the cascading risk of shifting all subsequent work back as well.

We're trying to avoid an issue we had last year by leaving too many feature lingering in nimbus/experiment configuration limbo by biasing towards rollout, and cleaning up nimbus flag pro-actively as soon as tests complete before adding too many new variations.

Comment 11

[Donal Meehan [:dmeehan]]

As mentioned, with the move to two weeks cycles, we won't take these uplifts in beta. It will ride the train with Fx157 only 2 weeks later.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Gabriel, do we want a release note here? Thanks.

Comment 13

[jhall]

Release Note Request (optional, but appreciated)
[Suggested wording]: Tapping the search field on the Firefox for Android homepage now shows your recent searches