Closed Bug 2068136 Opened 1 month ago Closed 1 month ago

[Nova] Sidebar icons have become low contrast with some themes and are inconsistent with toolbar icons

Categories

(Firefox :: Theme, defect, P2)

Firefox 156
defect

Tracking

()

VERIFIED FIXED
157 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox155 --- unaffected
firefox156 --- disabled
firefox157 --- verified

People

(Reporter: ke5trel, Assigned: kcochrane)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-sidebar][fidefe-nova])

Attachments

(2 files)

STR:

  1. Launch latest Nightly 157.0a1 with browser.nova.enabled = true.
  2. Install official theme Innovator – Balanced (80k users).
  3. Show sidebar tools.

Expected:
Sidebar icons are dark against pale background like the toolbar.

Actual:
Sidebar icons are light with low contrast instead of dark despite sharing same background color as toolbar.

Does not happen with browser.nova.enabled = false.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=551a03fc5906431d6bfc3b20a1fdae8ec4661d04&tochange=9d0b2f7ad33a24bb90bd9d40efe9024118ad236b

Regressed by Bug 2063294.

:kcochrane, since you are the author of the regressor, bug 2063294, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(kcochrane)
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Flags: needinfo?(kcochrane)
Whiteboard: [fidefe-sidebar][fidefe-nova]
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/64d42aa41d46 https://hg.mozilla.org/integration/autoland/rev/7ae9130241e5 Ensure sidebar icon colors have the right color across themes r=desktop-theme-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch

Reproduced the initial issue on Windows 11 using Firefox 157.0a1 (2026-09-01).
Verified as fixed on Windows 11, macOS 13 and Ubuntu 22 using the latest Nightly 157.0a1 (2026-09-09): for the official theme "Innovator – Balanced", the Sidebar icons are now dark against pale background, matching the toolbar icons. I also tested several themes from Top Rated Themes, sorted by Most users, and everything looks good, the Sidebar icons have the same color as the toolbar icons.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-done-c157/b156]
QA Contact: cbadau
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: