2068234 - [Fitts' Law] Split View tabs are not selectable from the edge of the tab strip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Split View, defect, P1)

Description

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Click Target Demo.mov

Tabs in a split view cannot be selected from the visual margins of their "wrapper", unlike normal tabs.

Happens for both horizontal and vertical tabs, in both Proton and Nova.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 2068234 - Ensure split view tabs are selectable from the edge of the tab strip

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2068234 - Make split view tabs selectable from the edge of the tab strip. r=kcochrane,desktop-theme-reviewers,tabbrowser-reviewers

An alternative to D326755 that gives a split view tab the same shape as a plain tab: the tab's own box reaches the edge of the tab strip through a negative margin and matching padding, and the tab stack takes over the divider and the inline padding the tab held before.

Behavior-neutral apart from the hit area: the background, content, wrapper and group line boxes measure the same across densities, pixel ratios, Nova and Proton, and D326755's test passes unchanged against it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3140419d11c4
https://hg.mozilla.org/integration/autoland/rev/70ad4fc723cf
Make split view tabs selectable from the edge of the tab strip. r=kcochrane,desktop-theme-reviewers,tabbrowser-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9219bc7aff2d
https://hg.mozilla.org/integration/autoland/rev/53c77f97d534
Revert "Bug 2068234 - Make split view tabs selectable from the edge of the tab strip. r=kcochrane,desktop-theme-reviewers,tabbrowser-reviewers" for causing bc tests failures at drag_splitview.js

Comment 5

[Silaghi Andreea]

Backed out for causing bc tests failures at drag_splitview.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/dragdrop/browser_drag_splitview.js | test_dragstart_below_splitview_does_not_grab - Uncaught exception in test - Error: drag has been started by the operation

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d7e6867ae05f
https://hg.mozilla.org/integration/autoland/rev/d972488b9886
Make split view tabs selectable from the edge of the tab strip. r=kcochrane,desktop-theme-reviewers,tabbrowser-reviewers

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/d972488b9886