2068488 - urlbar.bounce is never recorded for searches from the New Tab search bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

urlbar.bounce lists newtab_searchbar among its sap values, but no bounce is ever recorded for a search from the New Tab search bar.

Tracking starts in UrlbarInputBase.pickResult behind an if (this.window.gBrowser) whose comment leaves the content-process case open: "TBD if and how this should work for a moz-urlbar living in a content process." The triggers are the other half: handleBounceEventTrigger is called from _on_TabClose and from the tabs progress listener, both listeners on the chrome window's gBrowser, which the bar cannot reach from the content process.

browser/components/urlbar/tests/browser-newtab/browser_bounceTelemetry.js (bug 2068470) asserts the current behavior: neither navigating back nor closing the tab records a bounce, while the address bar in the same page does.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2068488 - Keep every urlbar bounce in one parent-side store keyed by the tab. r?mbeier!

One module-level map replaces the per-collector stores, so a trigger resolves the tab's bounce whichever input started it.

Behavior-neutral except in one spot: the direct path collects its snapshot before awaiting a prior bounce's trigger, where the engagement record that follows had already closed the view.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2068488 - Record urlbar.bounce for the New Tab search bar. r?mbeier!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf787af4a51b
https://hg.mozilla.org/integration/autoland/rev/8557e244b0dc
Keep every urlbar bounce in one parent-side store keyed by the tab. r=mbeier
https://github.com/mozilla-firefox/firefox/commit/a5b199f24922
https://hg.mozilla.org/integration/autoland/rev/6c883acea68c
Record urlbar.bounce for the New Tab search bar. r=mbeier

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/29349bf94fd2
https://hg.mozilla.org/integration/autoland/rev/43ee5cbe2cb8
Revert "Bug 2068488 - Record urlbar.bounce for the New Tab search bar. r=mbeier" for causing failures at browser_glean_telemetry_bounce_sap.js.

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_glean_telemetry_bounce_sap.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/43ee5cbe2cb8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=O16_SqZnS6qMoagOxbBVcw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6c883acea68cb8e17b5fa7163ca0fedd1df62fda

Failure log: https://treeherder.mozilla.org/logviewer?job_id=590476237&repo=autoland&task=O16_SqZnS6qMoagOxbBVcw.0&lineNumber=20773

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 2068488 - Resolve a bounce's sap when the engagement happens. r?mbeier!

A bounce records once the tab navigates away, by which point the address bar's sap no longer resolves to the page the search was made on: the direct path recorded a bounce as urlbar where its engagement had recorded urlbar_newtab. Keeping bounces in the parent-side store resolves the message path's sap at engagement time, leaving the two paths to disagree until this commit.

A bounce whose window closes before the trigger records too, where the closed window used to leave it without a sap. The sap test's urlbar expectation now matches the engagement sap test's, the first search of that session being on a blank page.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/80127a7218d7
https://hg.mozilla.org/integration/autoland/rev/fe54c180d124
Keep every urlbar bounce in one parent-side store keyed by the tab. r=mbeier
https://github.com/mozilla-firefox/firefox/commit/780d59d30aa4
https://hg.mozilla.org/integration/autoland/rev/fbe03de35a26
Resolve a bounce's sap when the engagement happens. r=mbeier
https://github.com/mozilla-firefox/firefox/commit/2f799b9a916b
https://hg.mozilla.org/integration/autoland/rev/cbf2d2c6efc5
Record urlbar.bounce for the New Tab search bar. r=mbeier

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fe54c180d124
https://hg.mozilla.org/mozilla-central/rev/fbe03de35a26
https://hg.mozilla.org/mozilla-central/rev/cbf2d2c6efc5