Closed Bug 2068513 Opened 10 days ago Closed 3 days ago

[wpt-sync] Sync PR 62239 - [Masonry] Add tests to ensure margins do not affect track opening and stacking axis alignment space

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
157 Branch
Tracking Flags:
Tracking Status
firefox157 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62239 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62239
Details from upstream follow.

Celeste Pan <celestepan@microsoft.com> wrote:

[Masonry] Add tests to ensure margins do not affect track opening and stacking axis alignment space

According to the spec, "Items that visually intrude into preceding empty
spaces (via negative margins, position: relative, transforms, etc.), do
not affect the size of those empty spaces" [1]. We should add test to
ensure that margins do not end up affecting track openings or stacking
axis alignment spaces.

[1] https://drafts.csswg.org/css-grid-3/#grid-lanes-layout-algorithm

Bug: 343257585, 517967196
Change-Id: If5d8d7cf1ee6b974c462e49163461161c38ffd1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8281147
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Commit-Queue: Celeste Pan \<celestepan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1689368}

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 171 tests

Status Summary

Firefox

PASS: 2
FAIL: 4[GitHub] 168[Gecko-windows11-64-25h2-debug] 169[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 4

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7b878e183589 https://hg.mozilla.org/integration/autoland/rev/6c79fbfe0c57 [wpt PR 62239] - [Masonry] Add tests to ensure margins do not affect track opening and stacking axis alignment space, a=testonly https://github.com/mozilla-firefox/firefox/commit/00ba535ac7fb https://hg.mozilla.org/integration/autoland/rev/b41138c1cd18 [wpt PR 62239] - Update wpt metadata, a=testonly
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0d0527ef5099 https://hg.mozilla.org/integration/autoland/rev/d718e102ccd2 Revert "Bug 2068513 [wpt PR 62239] - Update wpt metadata, a=testonly" https://github.com/mozilla-firefox/firefox/commit/4e64b911688c https://hg.mozilla.org/integration/autoland/rev/8cf1a1ce9061 Revert "Bug 2068513 [wpt PR 62239] - [Masonry] Add tests to ensure margins do not affect track opening and stacking axis alignment space, a=testonly"
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cf119c019ca2 https://hg.mozilla.org/integration/autoland/rev/f6bcb67819e9 [wpt PR 62239] - [Masonry] Add tests to ensure margins do not affect track opening and stacking axis alignment space, a=testonly https://github.com/mozilla-firefox/firefox/commit/5c749be20b9d https://hg.mozilla.org/integration/autoland/rev/dd8ef1b66d60 [wpt PR 62239] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f6bcb67819e9
https://hg.mozilla.org/mozilla-central/rev/dd8ef1b66d60

Status: NEW → RESOLVED
Closed: 3 days ago
status-firefox157: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in before you can comment on or make changes to this bug.