Closed Bug 2068560 Opened 9 days ago Closed 3 days ago

[wpt-sync] Sync PR 62358 - [Masonry] Support OOF fragmentation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
157 Branch
Tracking Flags:
Tracking Status
firefox157 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62358 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62358
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] Support OOF fragmentation

Out-of-flow grid-lanes descendants were only collected during the
initial layout pass. An item whose static position belonged to a later
fragment could therefore be added to the wrong fragment and laid out
incorrectly.

Persist pending OOF children in GridLanesBreakTokenData and restore
them for each continuation. Resolve static positions against the full
stitched block size, translate them into fragment-local coordinates, and
defer candidates until their position belongs in the current fragment.
This follows the grid fragmentation approach for both row and column
grid-lanes.

Add WPT coverage for alignment, nested and external containing blocks,
writing modes, fill and track reversal, intrinsic sizing, and explicit
grid areas. Expected failures reflect the remaining break-rule and row
expansion limitations of grid lanes in general.

Bug: 343257585
Change-Id: Id00a426e5965da01e48e0ea6ea2888823b1e12f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8327892
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1689953}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

PASS: 5[GitHub] 13[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 19[GitHub] 29[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 11
FAIL: 13

Safari

PASS: 17
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/95a9075ec08a
https://hg.mozilla.org/mozilla-central/rev/ab15559b9282

Status: NEW → RESOLVED
Closed: 3 days ago
status-firefox157: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
You need to log in before you can comment on or make changes to this bug.