2068632 - Non-parser created select element might not reflect selected option in .selectedOptions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Test-case.

Sorry for the claude test-case.

Anyway, this seems to be because a non-parser-inserted select never sets mDefaultSelectionSet. Haven't bisected yet:

https://searchfox.org/firefox-main/rev/8a99ef927ea16827f2089e2bdf6a1188ddf645e7/dom/html/HTMLSelectElement.cpp#1476,1484

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 2068632 - Set mDefaultSelectionSet for non-parser-created selects r?#dom-core,emilio

Bug 2038588, replaced TrySelectSomething, so that option selectedness is only
dirty via OnSelectionChanged. OnSelectionChanged returns early unless
mDefaultSelectionSet is set, and only DoneAddingChildren sets it.
This means it never runs for a select built by script. Removing the last
unselected option from such a combobox, or resetting its form, re-selects the
first enabled option but leaves selectedOptions stale.

This change moves to initialise mIsDoneAddingChildren in the constructor. It's
already set when the select is not parser-created. The result is that the early
return is skipped, allowing the selected option list to become dirty.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36658b19bd4d
https://hg.mozilla.org/integration/autoland/rev/48a3fb1cfc3c
Set mDefaultSelectionSet for non-parser-created selects r=emilio

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/48a3fb1cfc3c

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62446 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot