[wpt-sync] Sync PR 62382 - Reset pending selected scrollmarker on removal
Categories
(Core :: Layout: Scrolling and Overflow, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62382 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62382
Details from upstream follow.
Rune Lillesveen <futhark@chromium.org> wrote:
Reset pending selected scrollmarker on removal
A removed ScrollMarkerPseudoElement cleared the selected_marker_ of the
group if that matched the removed marker. We did not check
pending_selected_marker_, which could lead to a disconnected pending
marker being promoted as the selected marker in
ApplyPendingScrollMarker().This lead to a crash when calling
LayoutTreeBuilderTraversal::ComparePreorderTreePosition on elements not
in the flat tree.Bug: 533050757
Change-Id: I8540787e3aa7fc6da7376daae027e4e91079a351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8331127
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690507}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=227a41a5c0f9aa620a96899a6fe257ea5c095ad1
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
TIMEOUT: 1
Chrome
PASS : 1
Safari
TIMEOUT: 1
Links
Details
New Tests That Don't Pass
- /css/css-overflow/scroll-markers/scroll-marker-click-remove-crash.html [wpt.fyi]:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5872c5816da
https://hg.mozilla.org/mozilla-central/rev/fcb618593238
Description
•