2068970 - Go to the address in the Location Bar arrow button is facing the wrong direction in RTL builds

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: image.png

Notes

• Please see the attached screenshot for more details.
• Reproducible with both Proton and Nova.

Found in

• Nightly 157.0a1;

Affected versions

• Nightly 157.0a1;

Tested platforms

• Windows 11;
• Ubuntu 22;
• macOS 13;

Affected platforms

• Windows 11;
• Ubuntu 22;
• macOS 13;

Preconditions

• Use a ar or he build;

Steps to reproduce

1. Launch Firefox.
2. Focus the new tab search bar and input any string.

Expected result

• The “Go to the address in the Location Bar” arrow button is facing right.

Actual result

• The “Go to the address in the Location Bar” arrow button is facing left.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2068970 - Use :dir() instead of :-moz-locale-dir() for urlbar / searchbar RTL rules. r?adw!

:-moz-locale-dir() is a document-state pseudo-class, and Document::IsDocumentRightToLeft() returns false for anything but a chrome document, so those rules are inert in about:newtab, which links the same sheet through UrlbarInputBase. :dir() reads the dir attribute DOMLocalization puts on the root, and browser.xhtml and about:newtab both carry it.

The rules left on :-moz-locale-dir() target elements only the address bar or the legacy searchbar has. The overflow-mask rule anchors on .urlbarView instead of matching the row's own element, which can carry dir="auto".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2a9455153a2e
https://hg.mozilla.org/integration/autoland/rev/86ba489062f0
Use :dir() instead of :-moz-locale-dir() for urlbar / searchbar RTL rules. r=adw,desktop-theme-reviewers,emilio

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86ba489062f0

Comment 4

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox Nightly 157.0a1 -ar build- on Windows 10, Ubuntu 22, macOS 13.